Repository navigation
perf(utils): avoid quadratic suffix search in dedupe_keys - #921
Open
voidstackloop wants to merge 1 commit into
Open
voidstackloop wants to merge 1 commit into
voidstackloop wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In$O(N^2)$ string formatting and set lookups.
sqlite_utils.utils.dedupe_keys, when duplicate keys are encountered, the while loop checkednew_key in seen or new_key in takenstarting fromsuffix = 2on every single duplicate. For wide tables or queries with many duplicate columns, this resulted inThis change tracks the next available suffix per base key in
next_suffix, avoiding repeated re-checks of earlier suffixes and providing an 800x+ speedup on wide column sets while maintaining exact output naming compatibility.📚 Documentation preview 📚: https://sqlite-utils--921.org.readthedocs.build/en/921/