Repository navigation
smp-server: group pending notifications by service in one pass - #1973
Draft
evgeny-simplex wants to merge 2 commits into
Draft
evgeny-simplex wants to merge 2 commits into
evgeny-simplex wants to merge 2 commits into
Conversation
evgeny-simplex
requested review from
epoberezkin and
spaced4ndy
as code owners
October 25, 2026 07:32
evgeny-simplex
force-pushed
the
ep/ntf-service-grouping
branch
from
October 25, 2026 14:12
625cc4d to
0dcf655
Compare
epoberezkin
marked this pull request as draft
October 26, 2026 11:14
evgeny-simplex
force-pushed
the
ep/ntf-service-grouping
branch
from
October 26, 2026 11:39
7e71740 to
e3d06fb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In each notification delivery cycle, the server groups pending notifiers by the service of each notifier's queue in one pass, so the cycle cost is independent of the number of service records.
The class method, its result type and the delivery loop are unchanged. Groups without notifiers are no longer returned by the memory store, and its groups are ordered by service ID, as in the PostgreSQL store.