Repository navigation
xftp server: release storage of interrupted uploads - #1977
Merged
epoberezkin merged 2 commits intoOct 26, 2026
Merged
Conversation
evgeny-simplex
requested review from
epoberezkin and
spaced4ndy
as code owners
October 25, 2026 07:32
evgeny-simplex
force-pushed
the
ep/xftp-upload-reservation
branch
from
October 25, 2026 13:58
b2b599b to
551d16c
Compare
This was referenced Oct 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xftp server: when the connection of an upload closes while the file is being received, the storage reserved for the upload is released and the partial file is removed, as when the upload ends with an error. Asynchronous exceptions are masked from the reservation until the file is committed or the reservation is released; the transfer runs with them restored, and the reservation is released if the transfer ends with an exception. The two existing release blocks are replaced by one function, which is also called on that exception.
xftp server: file deletion and blocking run with asynchronous exceptions masked, so the storage of a deleted file is released also when the thread is interrupted after the file record is removed.
tests: after uploads are interrupted by closing their connections, the server files directory is empty and the whole storage quota is available.