fix(computer-use): protect more terminals, test the protected-app guard, and keep the approval copy for older shells

Author: waleedlatif1

apps/desktop/native/computer-use/ComputerUse.swift

@@ -150,12 +150,17 @@ let PROTECTED_APPS: Set<String> = [
     "org.keepassxc.keepassxc", "com.lastpass.lastpass", "in.sinew.enpass-desktop", "me.proton.pass.electron",
     "com.markmcguill.strongbox", "com.markmcguill.strongbox.mac",
     "com.apple.terminal", "com.googlecode.iterm2", "dev.warp.warp-stable", "com.mitchellh.ghostty",
+    "net.kovidgoyal.kitty", "org.alacritty", "com.github.wez.wezterm", "co.zeit.hyper", "org.tabby",
 ]
+/// Whether computer use refuses an app: Sim's own apps and `PROTECTED_APPS`. Bundle identifiers match
+/// case-insensitively in Launch Services.
+func isProtectedApp(_ bundle: String) -> Bool {
+    let key = bundle.lowercased()
+    return key == Bundle.main.bundleIdentifier?.lowercased() || key.hasPrefix("com.simstudio.") || key.hasPrefix("ai.sim.desktop") || PROTECTED_APPS.contains(key)
+}
 func appFor(_ bundleId: String?, launch: Bool = false) async throws -> NSRunningApplication {
     let bundle = try required(bundleId, "bundleId")
-    // Bundle identifiers match case-insensitively in Launch Services.
-    let key = bundle.lowercased()
-    guard key != Bundle.main.bundleIdentifier?.lowercased(), !key.hasPrefix("com.simstudio."), !key.hasPrefix("ai.sim.desktop"), !PROTECTED_APPS.contains(key) else {
+    guard !isProtectedApp(bundle) else {
         throw ComputerError("protected_app", "Computer use does not operate Sim, System Settings, password managers, or terminals; use the terminal tool for shell work.")
     }
     var apps = NSRunningApplication.runningApplications(withBundleIdentifier: bundle).filter { !$0.isTerminated }

apps/desktop/native/computer-use/tests/NativeTests.swift

@@ -26,6 +26,10 @@ import AppKit
         expectError("unsupported_key") { _ = try parseKey("F99") }
         expectError("invalid_arguments") { _ = try parseKey("Hyper+A") }
         expectError("invalid_arguments") { _ = try required(Optional<String>.none, "example") }
+        for bundle in ["com.apple.systempreferences", "com.apple.Terminal", "COM.GOOGLECODE.ITERM2", "net.kovidgoyal.kitty", "com.1password.1password", "com.apple.Passwords", "com.bitwarden.desktop", "ai.sim.desktop", "com.simstudio.computer-use"] {
+            precondition(isProtectedApp(bundle), bundle)
+        }
+        for bundle in ["com.apple.TextEdit", "com.apple.finder", "com.apple.Safari"] { precondition(!isProtectedApp(bundle), bundle) }
         var queue = AXTraversalQueue<String>(limit: 1000)
         queue.append(AXTraversalEntry(element: "menu", parent: nil, depth: 0, menu: true, priority: false))
         queue.append(AXTraversalEntry(element: "content", parent: nil, depth: 0, menu: false, priority: false))

apps/docs/content/docs/desktop/index.mdx

@@ -98,7 +98,7 @@ To enable it when available:
 1. Turn **Use apps on this Mac** to **On**.
 2. Select **Allow** next to **Accessibility** (app interaction) and **Screen Recording** (screenshots), grant them in System Settings, then return to Sim.
 
-Sim can then use any app except terminals, password managers, and macOS System Settings; shell work goes through **Terminal** access instead. To approve each app the first time Sim uses it, turn on **Ask before using a new app**; Sim then offers **Allow for This Task**, **Always Allow**, or **Cancel**.
+Sim can then use any app except terminals, password managers, and macOS System Settings (and Sim itself); shell work goes through **Terminal** access instead. To approve each app the first time Sim uses it, turn on **Ask before using a new app**; Sim then offers **Allow for This Task**, **Always Allow**, or **Cancel**.
 
 Sim can read app windows and interact through clicks, text, keyboard shortcuts, scrolling, and supported accessibility controls. Screenshots and returned app content can be sent to your Sim deployment and model. Some actions require bringing the app to the foreground; app compatibility and macOS permissions can still limit what succeeds.
 

apps/sim/app/workspace/[workspaceId]/settings/components/desktop/computer-use.tsx

@@ -85,7 +85,9 @@ function ComputerUseSettingsControls() {
           />
         </div>
         <p className='text-[var(--text-muted)] text-sm'>
-          Sim can use any app except terminals, password managers, and System Settings.
+          {askForApps === undefined
+            ? 'Each app needs your approval before Sim can use it.'
+            : 'Sim can use any app except terminals, password managers, System Settings, and Sim itself.'}
         </p>
         {error && (
           <div className='flex items-center justify-between text-sm'>