fix(computer-use): click an editor into focus when Accessibility cannot focus it by waleedlatif1 · Pull Request #10004 · simstudioai/sim

waleedlatif1 · 2026-11-13T19:25:42Z

Summary

type_text / input_sequence refused in SwiftUI sheets that ignore an Accessibility focus request — e.g. Clock's "Add a clock" city search kept focus on the sheet's group, so typing a city failed with "The exact editor is no longer focused" (3 multi-app benchmark tasks hit it, one lost its city)
When the app is in front and the AX focus request did not take, the helper now clicks the editor's center the way a user would — only if that point hit-tests to the editor itself inside its observed window, through the existing coordinate-input guards (foreground app, unchanged window geometry, receiving app/window) — then runs the usual focus checks before any keystroke. Background apps and covered or mismatched points send nothing

Type of Change

Bug fix

Testing

Probe on macOS 26 (Clock → Add a clock → type "Pretoria"): staging helper refuses with the focus error and the field stays empty; this helper types it and the field reads "Pretoria"
Live fixture test with this helper: PASS (AX click/set/action, Unicode typing, chords, drag/scroll, refusals, date picker, window-target typing, batch scenarios)
Swift typecheck; full gate in CI

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ot focus it SwiftUI sheets such as Clock's city search ignore an Accessibility focus request, so type_text refused with 'the exact editor is no longer focused'. In a foreground app the helper now clicks the editor's center, only when that point hit-tests to the editor inside its observed window, then applies the usual focus checks.

vercel · 2026-11-13T19:25:44Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Nov 13, 2026 7:54pm UTC

greptile-apps · 2026-11-13T19:28:33Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Adds guarded click-to-focus for editors that ignore Accessibility focus requests.

Text entry clicks an editor when Accessibility cannot focus it.

_{Reviews (4) · Last reviewed commit: "fix(computer-use): never click a secure ..." · Reviewed by Greptile}

cubic-dev-ai

All reported issues were addressed across 2 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

…e it, and cover click-to-focus in the live fixture

…ick-to-focus refusal

waleedlatif1 · 2026-11-13T19:37:03Z

@greptile

waleedlatif1 · 2026-11-13T19:37:05Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-13T19:37:11Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 4 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-13T19:45:43Z

@greptile

waleedlatif1 · 2026-11-13T19:45:44Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-13T19:45:50Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 4 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-13T19:55:25Z

@greptile

waleedlatif1 · 2026-11-13T19:55:26Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-13T19:55:33Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 4 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 added 2 commits November 13, 2026 11:20

docs(computer-use): describe the click-to-focus fallback

8851e5e

vercel Bot temporarily deployed to Preview November 13, 2026 19:25 Inactive

greptile-apps Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/desktop/native/computer-use/ComputerUse.swift Resolved

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/desktop/native/computer-use/ComputerUse.swift Resolved

Comment thread apps/desktop/native/computer-use/ComputerUse.swift Resolved

fix(computer-use): click only onto the editor or a text control insid…

4479dca

…e it, and cover click-to-focus in the live fixture

vercel Bot temporarily deployed to Preview November 13, 2026 19:34 Inactive

test(computer-use): move focus away before checking the background cl…

b6ed676

…ick-to-focus refusal

vercel Bot temporarily deployed to Preview November 13, 2026 19:36 Inactive

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/desktop/native/computer-use/ComputerUse.swift Resolved

fix(computer-use): check for Stop before the click-to-focus mouse-down

b96170a

vercel Bot temporarily deployed to Preview November 13, 2026 19:45 Inactive

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/desktop/native/computer-use/ComputerUse.swift Resolved

fix(computer-use): never click a secure field into focus

a739a8a

vercel Bot temporarily deployed to Preview November 13, 2026 19:54 Inactive

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

waleedlatif1 merged commit 6cb5bfc into staging Nov 13, 2026
50 checks passed

waleedlatif1 deleted the fix/computer-use-focus-by-click branch November 13, 2026 21:02

waleedlatif1 mentioned this pull request Nov 13, 2026

fix(computer-use): tighten batch and click-to-focus edge cases from the staging audit #10012

Merged

6 tasks done

waleedlatif1 mentioned this pull request Nov 13, 2026

v0.9.57: cua improvements, Monaco CRM integration, Hex and Stripe validation, keyless subjects held until trust policies apply, AWS Marketplace replica entitlement check, Slack channel search #10017

Merged

Conversation

waleedlatif1 commented Nov 13, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Nov 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Nov 13, 2026 •

edited

Loading

greptile-apps Bot commented Nov 13, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading