Skip to content

improvement(search): name matching Slack channels and say whether a filtered channel exists - #10007

Merged
waleedlatif1 merged 3 commits into
stagingfrom
improvement/search-slack-channels
Nov 13, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
improvement/search-slack-channels

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Slack RTS returns the same empty page for a quiet channel, a misspelled channel name, and a channel that does not exist, and the search had no way to look a channel up by name, so a client had to guess channel names
  • A Slack search with text now also asks RTS for matching channels (same call, content_types: channels) and names up to 5 in the account status with the in:<#ID> filter for each; channels the source settings exclude, and archived ones when archived channels are excluded, are never named
  • When a query filtered with in:#name finds nothing, one channel lookup says either that the channel exists and nothing in it matched the query and date window, or that no channel with that name is visible, with similar names; a failed lookup leaves the search as it was

Type of Change

  • Improvement

Testing

  • New tests in providers.test.ts (channel listing with policy filtering, channel exists, channel missing, failed lookup) fail on the old code and pass on the new; dates.test.ts passes
  • Control vs candidate on a test workspace: identical result lists on 20 Slack questions and 5 targeted channel queries, no added latency; only the account status text changes

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 13, 2026 9:08pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Adds Slack channel suggestions and explains empty searches filtered by channel name.

  • Slack text searches show matching channel names and filters.
  • Empty Slack channel filters explain whether the named channel is visible.

Reviews (2) · Last reviewed commit: "fix(search): say a filtered Slack channe..." · Reviewed by Greptile

Comment thread apps/sim/lib/sim-search/live/slack.ts Resolved
Comment thread apps/sim/lib/sim-search/live/slack.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/sim-search/live/slack.ts Resolved
Comment thread apps/sim/lib/sim-search/live/slack.ts Resolved
…hole lookup, and only when no result page remains
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — f22e0ad5 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant