Repository navigation
improvement(search): name matching Slack channels and say whether a filtered channel exists - #10007
Merged
Merged
Conversation
…iltered channel exists
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryAdds Slack channel suggestions and explains empty searches filtered by channel name.
Reviews (2) · Last reviewed commit: "fix(search): say a filtered Slack channe..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…hole lookup, and only when no result page remains
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content_types: channels) and names up to 5 in the account status with thein:<#ID>filter for each; channels the source settings exclude, and archived ones when archived channels are excluded, are never namedin:#namefinds nothing, one channel lookup says either that the channel exists and nothing in it matched the query and date window, or that no channel with that name is visible, with similar names; a failed lookup leaves the search as it wasType of Change
Testing
providers.test.ts(channel listing with policy filtering, channel exists, channel missing, failed lookup) fail on the old code and pass on the new;dates.test.tspassesChecklist
test-auditauthoring gate)