Skip to content

improvement(search-mcp): log why a batched read returned an error for a document - #10010

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/search-mcp-batch-read-errors
Nov 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/search-mcp-batch-read-errors

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • When a batched read_document returns an error entry for a document (a stale or altered ID, a scope change, a provider failure), the server now logs the caller-facing reason at info level
  • Before, only unexpected failures were logged, so a batched call that returned errors for every document looked like a success in the logs
  • Follow-up to improvement(search-mcp): log rejected tool-call fields and batched read errors #10003, which merged before this commit landed on its branch

Type of Change

  • Improvement

Testing

  • server.test.ts and server.protocol.test.ts pass; biome clean

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 13, 2026 9:09pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Adds an info-level log when a batched read_document returns a known error for a document.

  • Batched reads now log each caller-facing document error.

Reviews (1) · Last reviewed commit: "improvement(search-mcp): log why a batch..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 823f9f1 into staging Nov 13, 2026
62 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/search-mcp-batch-read-errors branch November 13, 2026 21:13

This branch was previously deployed

1 inactive deployment
Preview — d504da62 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant