fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point lands by waleedlatif1 · Pull Request #10013 · simstudioai/sim

waleedlatif1 · 2026-11-13T21:24:02Z

Summary

Typing into a top-page field that something covers still goes through keyboard focus, but now refuses when the cover sits in an unmarked fixed layer spanning the viewport (a modal built from a plain backdrop + panel, no role="dialog"/aria-modal). A full-screen fixed app shell that also holds the field still types
Refuses when every sampled point hits nothing, instead of treating empty hits as a non-modal cover
The field's ancestor chain is computed once and sampled hits are deduped, so the check costs one walk per distinct cover
The never-settling settle test now asserts the 2s cap (from the first probe) instead of only that a snapshot happened

Type of Change

Bug fix

Testing

New tests: refuses behind an unmarked full-screen layer, refuses when no point lands, still types under a fixed bar, still types inside a full-screen app shell. The two refusal tests fail with the fix reverted
apps/desktop/src/main/browser-agent/ vitest: 557 passed
lint, type-check, generators, test:scripts clean
Paired browser-agent benchmark (REAL v2, WebGames, capbench) against staging, results in a comment below

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…dal or when no sampled point lands Top-page typing through a covering element now also refuses when the cover sits in a fixed layer spanning the viewport that does not hold the field, and when every sampled point hits nothing. The never-settling settle test now asserts the cap.

… sampled hits, and time the settle cap from its first probe

…ound the settle cap from below

vercel · 2026-11-13T21:24:06Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Nov 13, 2026 10:22pm UTC

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-11-13T21:27:48Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The PR refuses typing behind an unmarked full-screen backdrop or when no sampled point hits anything.

Top-page typing stops behind full-screen covers and empty hit samples.
The never-quiet page test checks the existing two-second wait cap.

Since the previous review, only test callbacks changed. Their behavior is unchanged. No new actionable issues or repository-rule violations were found.

_{Reviews (5) · Last reviewed commit: "test(desktop-browser): type the corner s..." · Reviewed by Greptile}

… when it catches the pointer

waleedlatif1 · 2026-11-13T21:31:25Z

@greptile

waleedlatif1 · 2026-11-13T21:31:26Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-13T21:31:31Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

…t for the layer that covers the field

waleedlatif1 · 2026-11-13T21:43:55Z

@greptile

waleedlatif1 · 2026-11-13T21:43:57Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-13T21:44:03Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 3 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

…der every viewport corner as a modal backdrop

…n container

waleedlatif1 · 2026-11-13T22:03:52Z

@greptile

waleedlatif1 · 2026-11-13T22:03:53Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-13T22:03:59Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-13T22:22:58Z

@greptile

waleedlatif1 · 2026-11-13T22:22:59Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-13T22:23:05Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 added 4 commits November 13, 2026 13:14

refactor(desktop-browser): compute the field's ancestors once, dedupe…

54e6697

… sampled hits, and time the settle cap from its first probe

test(desktop-browser): pass only the element to visible() from map

f716d61

test(desktop-browser): drop a typing assertion that cannot fail and b…

27f916a

…ound the settle cap from below

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

greptile-apps Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/desktop/src/main/browser-agent/page-functions.ts Resolved

fix(desktop-browser): count a full-screen fixed layer as a modal only…

6a28b98

… when it catches the pointer

vercel Bot temporarily deployed to Preview November 13, 2026 21:31 Inactive

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

greptile-apps Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/desktop/src/main/browser-agent/page-functions.ts Resolved

fix(desktop-browser): detect an unmarked modal by probing the viewpor…

285e4f0

…t for the layer that covers the field

vercel Bot temporarily deployed to Preview November 13, 2026 21:43 Inactive

greptile-apps Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/desktop/src/main/browser-agent/page-functions.ts Resolved

Comment thread apps/desktop/src/main/browser-agent/page-functions.ts Resolved

Comment thread apps/desktop/src/main/browser-agent/page-functions.ts Resolved

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/desktop/src/main/browser-agent/page-functions.ts Resolved

fix(desktop-browser): treat an element painted above the field and un…

b038c1b

…der every viewport corner as a modal backdrop

vercel Bot temporarily deployed to Preview November 13, 2026 22:02 Inactive

test(desktop-browser): cover a field painted below its own full-scree…

e26a85a

…n container

vercel Bot temporarily deployed to Preview November 13, 2026 22:03 Inactive

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

test(desktop-browser): type the corner stacks as Element arrays

2c82449

vercel Bot temporarily deployed to Preview November 13, 2026 22:22 Inactive

waleedlatif1 merged commit d9af98b into staging Nov 13, 2026
36 checks passed

waleedlatif1 deleted the fix/desktop-browser-covered-field-typing branch November 13, 2026 22:22

waleedlatif1 mentioned this pull request Nov 13, 2026

v0.9.57: cua improvements, Monaco CRM integration, Hex and Stripe validation, keyless subjects held until trust policies apply, AWS Marketplace replica entitlement check, Slack channel search #10017

Merged

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

Conversation

waleedlatif1 commented Nov 13, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Nov 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Nov 13, 2026 •

edited

Loading

greptile-apps Bot commented Nov 13, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading