Repository navigation
improvement(blocks): share the tool-call fallback helper and tidy the Hex/Stripe validation code - #10014
Merged
Conversation
… Hex/Stripe validation code
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryShares the tool-call fallback across ten blocks and removes repeated Stripe cursor code.
Acknowledged intentional change: Reviews (1) · Last reviewed commit: "improvement(blocks): share the tool-call..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isToolCall(context)/toolCallArg(context, value)toblocks/utils.ts. The "use the model's tool-named arg only on a tool call" rule from fix(hex,stripe): validate Hex and Stripe against their API docs #10005/fix(blocks): keep agent-supplied tool args that block mappers remap from dedicated fields #10006/fix(google-drive): keep the page token an agent passes #10008 is now written once instead of hand-rolled in 10 blocks:agentArgclosures (outlook's returnednull, the othersundefined);isAgentCallpredicates;context?.operation ? … : undefinedternaries.listCursorParams/appendListCursorshelper replaces the cursor params and guard copied into the 8 list tools;opand the redundant checks in update/create subscription are removed.emptyToUndefined, plus onefieldOrToolArgfor the cursor and user id fallbacks.it.eachthat only exercised one branch;requestUrltakes the context instead of three inline copies;requireParamsMapperhelpers are gone.Type of Change
Testing
check:utils,check:test-patterns,check:comment-hygiene,check:file-names,check:explicit-anyandcheck-block-registry origin/stagingpass, plus lint and type-check in the pre-push hook.Checklist
test-auditauthoring gate)🤖 Generated with Claude Code