Repository navigation
fix(computer-use): type after a focus click only once the caret is confirmed at the end - #10019
Merged
Merged
Conversation
…nfirmed at the end The click-to-focus fallback typed at the click point when the editor exposed no settable selection range or no string value, or when focus settled only after its poll. It now reads the editor's length (value or AXNumberOfCharacters), accepts an empty editor or a caret already at the end, verifies a caret move by reading the range back, and otherwise refuses with caret_unconfirmed before any keystroke. An input_sequence that starts with Cmd+A skips the check, since it replaces the value.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge based on the reviewed changes. SummaryThe PR requires a confirmed end-of-text caret before typing after a focus click. A sequence starting with Cmd+A skips that check.
Reviews (2) · Last reviewed commit: "test(computer-use): cover the caret_unco..." · Reviewed by Greptile |
…r that ignores caret moves
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AXNumberOfCharacters; an empty editor or a caret already at the end qualifies; a move counts only when the selection range reads back at the end; anything else (unknown length, unsettable range, failed read-back, focus not settled) refuses withcaret_unconfirmedbefore any keystrokeinput_sequencewhose first step is Cmd+A skips the check, since it replaces the value regardless of the caretType of Change
Testing
Checklist
test-auditauthoring gate)