Repository navigation
fix(monaco): reject a stage key and a stage ID together on opportunity writes - #10020
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge. SummaryOpportunity writes now reject a nonblank
No actionable issues found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "fix(monaco): reject a stage key and a st..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stageandstageIdtogether. Monaco's spec documentsstage_idas a replacement forstageon both create and update ("Stage ID ..., instead ofstage"), and gives no meaning to sending both, so the request was ambiguous.buildMonacoOpportunityWriteBody, so both tools get it. It reads the already-trimmed body, so a blank stage key next to a stage ID is still allowed. The wording matches the existing "Provide either X or Y, not both" checks.stageIdparam descriptions now say to provide one or the other.Type of Change
Testing
tools/monaco/write_bodies.test.ts. It fails with the check removed and passes with it in place.write_bodies.test.tsandblocks/blocks/monaco.test.tspass.check:tool-metadata,check:docs,check:utils,check:integration-catalog,check:tool-param-reachabilityandcheck-block-registry.ts origin/stagingpass.Checklist
test-auditauthoring gate)