Skip to content

fix(monaco): reject a stage key and a stage ID together on opportunity writes - #10020

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/monaco-opportunity-stage
Nov 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/monaco-opportunity-stage

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Type of Change

  • Bug fix

Testing

  • New case in tools/monaco/write_bodies.test.ts. It fails with the check removed and passes with it in place.
  • write_bodies.test.ts and blocks/blocks/monaco.test.ts pass.
  • check:tool-metadata, check:docs, check:utils, check:integration-catalog, check:tool-param-reachability and check-block-registry.ts origin/staging pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 13, 2026 10:50pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Opportunity writes now reject a nonblank stage and stageId together.

  • Opportunity writes reject requests that name a stage two ways.

No actionable issues found. Tests were not run during this review.

Reviews (1) · Last reviewed commit: "fix(monaco): reject a stage key and a st..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 68f4c69 into staging Nov 13, 2026
83 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/monaco-opportunity-stage branch November 14, 2026 00:29

This branch was successfully deployed

1 active deployment
Preview — 32751240 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant