Repository navigation
fix(credentials): cap the Databricks identity check with a deadline and report no hold for an unheld reconnect subject - #10021
Merged
Conversation
…nd report no hold for an unheld reconnect subject
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds a 15-second deadline to the Databricks identity request and stops reporting a hold for reconnect subjects Sim does not hold.
Reviews (1) · Last reviewed commit: "fix(credentials): cap the Databricks ide..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from release review on the held keyless subjects change (#10011).
/Meverification moved to the egress-guarded fetch, whosetimeoutonly resets on inactivity. It now also passessignal: AbortSignal.timeout(15s), so a slow or dribbling workspace can't hold a save open, and DNS validation is capped too. This restores the absolute deadline the oldfetchcall had, matching the other Databricks calls in the file.subjectHeldUntil. NowsubjectIssuedAt,subjectHeldUntilandsubjectReusedare absent on that path: optional on the internal contract and the use-case result only. The v2 contract still requires them, and its adapter asserts them, since it only issues or renews held subjects. The connect dialog's hint narrows on the optional field. Nothing displayed the unheld values before, so there's no visible change.keyless-subjectusage fences record their new size (bytes54).prepareWorkloadIdentity.Type of Change
Testing
AbortSignal.timeout.prepare-workload-identity, the v2 subjects route and the Databricks server tests.workload-identity-pending-subject.integration.ts(10) andworkload-identity-subject-reuse.integration.ts(9) pass against Postgres provisioned through migrations.bun run lint,check:audits(all),check:test-typesand the docs compatibility check pass. The generated artifacts are unchanged.Checklist
test-auditauthoring gate)