Repository navigation
improvement(search): skip the Slack channel lookup on channel-scoped searches and read channel names in any script - #10023
Merged
Conversation
…searches and read channel names in any script
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge. SummaryThis PR avoids extra Slack channel lookups and expands channel-name parsing.
Reviews (1) · Last reviewed commit: "improvement(search): skip the Slack chan..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
in:<#ID>, and drops the status notes of the empty ones. When the query also had anin:#namefilter, every empty per-channel search spent an extra rate-limited RTS channel lookup on a note that was then thrown away. A query that already carries anin:<#ID>scope now gets no lookupin:#general.looks upgeneralType of Change
Testing
providers.test.ts(no lookup on a channel-scoped search; channel names with trailing punctuation, accented and combining-mark scripts) fail on the old code and pass on the newlib/sim-search/live/**andlib/knowledge/mcp/**suites pass (524 tests); biome cleanChecklist
test-auditauthoring gate)