Skip to content

improvement(search): skip the Slack channel lookup on channel-scoped searches and read channel names in any script - #10023

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/search-slack-channel-followups
Nov 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/search-slack-channel-followups

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • A Slack source limited to selected channels runs one search per allowed channel, each scoped with in:<#ID>, and drops the status notes of the empty ones. When the query also had an in:#name filter, every empty per-channel search spent an extra rate-limited RTS channel lookup on a note that was then thrown away. A query that already carries an in:<#ID> scope now gets no lookup
  • The channel-name filter now reads names in any script, including combining marks, and drops a trailing period, so in:#general. looks up general
  • "No channel named #x is visible to this account" becomes "No channel named #x can be searched here", which is also true for a channel the source settings exclude
  • The logged-keys TSDoc in the MCP argument logging now names the real bound on a rejection's size, the route's request body cap

Type of Change

  • Improvement

Testing

  • New tests in providers.test.ts (no lookup on a channel-scoped search; channel names with trailing punctuation, accented and combining-mark scripts) fail on the old code and pass on the new
  • lib/sim-search/live/** and lib/knowledge/mcp/** suites pass (524 tests); biome clean

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…searches and read channel names in any script
@vercel

vercel Bot commented Nov 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 13, 2026 10:56pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

This PR avoids extra Slack channel lookups and expands channel-name parsing.

  • Slack search skips extra channel lookups and reads channel names more fully.
  • MCP logging notes point to the request body cap.

Reviews (1) · Last reviewed commit: "improvement(search): skip the Slack chan..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 9cad5ff into staging Nov 13, 2026
80 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/search-slack-channel-followups branch November 14, 2026 00:29

This branch was previously deployed

1 inactive deployment
Preview — d0e0f4f0 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant