Repository navigation
feat(desktop): quick chat window on a global shortcut - #10025
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryAdds a floating Quick Chat window with a configurable global shortcut, workspace-aware routing, and no desktop bridge.
Reviews (3) · Last reviewed commit: "test(desktop): resize the quick chat wit..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 18 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…and load-failure edges
…app lifetime on Windows and Linux
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
frame-ancestors 'none'still keeps it unframeablecheck:desktop-bridgepasses)Type of Change
Testing
apps/desktop/e2e/quick-chat.spec.ts(real shell against a fixture origin): opens scoped to the last workspace as an always-on-top window, gets no desktop bridge while full windows keep it, Open in Sim opens a full window and leaves the panel open, toggle brings a background panel forward then hides it with the page kept, sign-out destroys itdesktop-settings,ipc,menu,trayunit suites and the desktop settings component test passcheck:desktop-bridge, biome on changed filesChecklist
test-auditauthoring gate)