Repository navigation
fix(integrations): validate square, quickbooks, oracle fusion, sap, and workday; show the oracle fusion icon - #10029
Merged
Merged
Conversation
…surface catalog related_objects and id_mappings
…renamed subBlocks
…acle icon is visible
…ently-named subBlocks
…load and drop fields the services do not expose
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[High impact] The PR appears safe to merge, with a non-blocking loss of SAP item fields in the output picker and type lookup. Findings
SummaryFixes integration requests, returned fields, and the Oracle Fusion icon.
Reviews (2) · Last reviewed commit: "fix(integrations): clamp Workday page si..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 60 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…chema fixes with tests, and align SAP list output schemas
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validated Square, QuickBooks, Oracle Fusion Financials, SAP Concur, SAP S/4HANA, and Workday against vendor specs, and fixed the invisible Oracle Fusion icon.
bgColormatched the Oracle logo fill (#C74634), so the icon was invisible; now white like the Oracle DB and NetSuite blocks. All requests checked against the 26b OpenAPI and unchangednullfor untouched blank fields, which Square treats as "remove this field" and so erased customer data; blank fields are now omittedrelated_objects(Get Catalog Object) andid_mappings(Upsert Catalog Object) outputsd/d.resultsenvelope the tools already unwrap, plus fields the services don't expose. Outputs now match the payload. No request changes_Event_Responseelements[]Type of Change
Testing
update_customertest and QuickBooks block tests (fail on old code)blockstests,check-block-registry,check:tool-metadata,check:docs,check:docs-manifest,check:integration-catalog, biomeChecklist
test-auditauthoring gate)