Skip to content

fix(integrations): validate square, quickbooks, oracle fusion, sap, and workday; show the oracle fusion icon - #10029

Merged
waleedlatif1 merged 10 commits into
stagingfrom
fix/validate-finance-integrations
Nov 14, 2026
Merged

waleedlatif1 merged 10 commits into
stagingfrom
fix/validate-finance-integrations

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Validated Square, QuickBooks, Oracle Fusion Financials, SAP Concur, SAP S/4HANA, and Workday against vendor specs, and fixed the invisible Oracle Fusion icon.

  • Oracle Fusion Financials: bgColor matched the Oracle logo fill (#C74634), so the icon was invisible; now white like the Oracle DB and NetSuite blocks. All requests checked against the 26b OpenAPI and unchanged
  • Square:
    • Update Customer sent null for untouched blank fields, which Square treats as "remove this field" and so erased customer data; blank fields are now omitted
    • Added the documented related_objects (Get Catalog Object) and id_mappings (Upsert Catalog Object) outputs
  • QuickBooks: on agent tool calls the mapper wiped model args for every param backed by a renamed subBlock (email/PDF, attachments, reads, reports, purchasing/journal updates); these now fall back to the model's value. Canvas runs are unchanged
  • SAP Concur: same agent-path fix for user, sort, date filters, paging, and travel request fields. All endpoints verified against developer.concur.com
  • SAP S/4HANA: output schemas described the OData d/d.results envelope the tools already unwrap, plus fields the services don't expose. Outputs now match the payload. No request changes
  • Workday (checked against the v45 WSDL/XSDs):
    • Hire/Terminate now parse the _Event_Response elements
    • Get Compensation reads the real element names, where it previously always returned []
    • Update Personal Information, Create Pre-Hire, Terminate, and Hire requests are now schema-valid (wrong element names, element order, an attribute sent as an element, a missing required element)
    • Organization descriptors are now populated

Type of Change

  • Bug fix

Testing

  • New Square update_customer test and QuickBooks block tests (fail on old code)
  • Affected integration suites (279 tests), blocks tests, check-block-registry, check:tool-metadata, check:docs, check:docs-manifest, check:integration-catalog, biome
  • Independent audit of every hunk against vendor specs and saved-workflow compatibility

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 14, 2026 2:02am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge, with a non-blocking loss of SAP item fields in the output picker and type lookup.

Findings

  1. P2 SAP item fields disappear ▶

Summary

Fixes integration requests, returned fields, and the Oracle Fusion icon.

  • Workday calls now send and read the fields Workday expects.
  • QuickBooks agent calls keep values from the model when block fields are empty.
  • SAP Concur agent calls keep model values for mapped fields.
  • Square customer updates leave untouched fields out of the request.
  • Square catalog calls now return related objects and permanent ID mappings.
  • SAP S/4HANA tools describe the entities and lists they return.
  • SAP S/4HANA filter hints now use an example field from the prompt.
  • The Oracle Fusion Financials icon now appears on a white background.

Reviews (2) · Last reviewed commit: "fix(integrations): clamp Workday page si..." · Reviewed by Greptile

Comment thread apps/sim/lib/internal/workday/client.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 60 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 64 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 286ead3 into staging Nov 14, 2026
83 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/validate-finance-integrations branch November 14, 2026 02:47

This branch was successfully deployed

1 active deployment
Preview — dc84b950 Deployed Nov 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant