Repository navigation
improvement(api): log the v2 error code, field, and refusal reason on the request's closing line - #10033
Merged
Conversation
… the request's closing line
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge. SummaryAdds response-specific error details to the route handler’s closing error log.
|
…nd log only the declared top-level field
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
4xxlogs onlyClient error responsewith its status, so a400from bad input can't be told apart from one the API refuses by design without reproducing the callv2Errorrecords the response'serror.code, plus itsdetails.codewhen the refusal names one, against the response object it builds.v2ValidationErroradds the slice and its top-level field (body.mapping) and the Zod issue kind (invalid_type)withRouteHandlerreads that summary off the response it actually returns and addserrorCode/errorField/errorReasonto its closing line. A response built only to extract a message is never loggedType of Change
Testing
v2ValidationError/v2Errorhelpers: a record-key failure logsbody.mappingwhile the response still names the full path;details.codecomes through as the reason; an untagged response reads back nothingapp/api/v2/libandwith-route-handlertests (33) pass; biome,check:comment-hygiene,check:test-patternsclean; CI runs the restChecklist
test-auditauthoring gate)