fix(integrations): address release review findings on the integration sweep by waleedlatif1 · Pull Request #10039 · simstudioai/sim

waleedlatif1 · 2026-11-14T05:12:30Z

Summary

Fixes the release review findings on the v0.9.58 integration sweep (#10027–#10031, #10035, #10036). Each finding was re-verified by an independent subagent before fixing.

Agent tool calls resolve their operation (QuickBooks, SAP Concur, Attio, Intercom, Notion, Box, HubSpot)

An agent tool stores its operation outside params and passes it only as context.operation. These mappers branched on params.operation, so on agent calls the effects were:
- SAP Concur: every call threw "Unsupported SAP Concur operation" and fell back to raw params, which dropped receipt files.
- QuickBooks: a "yes" void confirmation reached the tool as a string, so voids always failed.
- Attio: a picked list was dropped.
- Intercom and Notion: booleans and JSON were left uncoerced.
They now use params.operation ?? context?.operation. Every branch that now runs was checked for model arguments it could overwrite:
- QuickBooks keeps the tool-row file on attachments.
- Intercom accepts a boolean true.
- Notion accepts already-parsed filter/sorts.
Canvas runs always carry params.operation, so they behave exactly as before.
This stays per-block opt-in on purpose. Injecting the operation centrally would turn on overwrites that are dormant today in about 200 mappers nobody has checked.

Validation and request fixes

Asana: limit: 0 now gets a 400 instead of silently falling back to the default.
Intercom: snooze times must be positive whole Unix timestamps. Ticket snooze uses the same check.
Mailchimp:
- templateId must be a positive integer, where it used to be sent as null for non-numeric input.
- Batch operations is typed json, so agents can send arrays.
- Update Audience gets its own email type dropdown with "Keep current" first. Saved workflows keep their stored value, and a null value no longer becomes false.
Airtable: pageSize is clamped to the documented 1–100.
Dropbox: List Folder path and Search query stop being required once a continuation cursor is set.

Cleanup

The two identical Intercom mappers are now one mapIntercomParams.
The shared toBooleanFromInput and parseOptionalJsonInput helpers replace hand-written copies.
Duplicated test helpers are merged.

Type of Change

Bug fix

Testing

New regression tests for every fix: QuickBooks, SAP Concur, Attio, Intercom, Notion, Dropbox, Asana, Mailchimp, Airtable. Each was confirmed to fail on the pre-fix code.
Affected suites: 723 tests across 92 files.
check-block-registry, check:tool-metadata, check:docs, check:integration-catalog, check:explicit-any (baseline shrunk), check:test-patterns, biome.
An independent audit simulated agent tool calls for every operation of every touched block against base and branch trees, and found no model argument overwritten.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…Mailchimp template ids, clamp Airtable page size, accept Mailchimp batch arrays, and keep the Mailchimp email type option on update

… SAP Concur, Attio, Intercom, Notion, Box, and HubSpot mappers

…oolean and JSON input helpers, and drop duplicated test helpers

… value is null

vercel · 2026-11-14T05:12:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Nov 14, 2026 6:15am UTC

cubic-dev-ai

All reported issues were addressed across 27 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-11-14T05:16:42Z

Confidence Score: 5/5

[High impact] The PR appears safe to merge; no blocking issues remain.

Summary

The PR fixes integration parameter mapping, input checks, and dropdown defaults.

Agent calls now reach the selected integration operation.
Intercom accepts only positive whole-number snooze times.
Intercom and Pipedrive show “No change” when an operation is unknown.
Asana keeps a supplied zero limit for request validation.
Airtable list requests keep page sizes between 1 and 100.
Dropbox continuation requests no longer need the starting path or query.
Mailchimp audience choices default differently for creating and updating.
Mailchimp checks campaign template IDs and accepts batch operations as JSON.

_{Reviews (7) · Last reviewed commit: "fix(asana): treat a whitespace-only limi..." · Reviewed by Greptile}

… and tighten presence checks for Intercom, Airtable, Dropbox, and QuickBooks inputs

waleedlatif1 · 2026-11-14T05:25:20Z

@greptile

waleedlatif1 · 2026-11-14T05:25:22Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-14T05:25:27Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 27 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

…ation's first option and validate the Intercom ticket snooze on tool calls

waleedlatif1 · 2026-11-14T05:45:26Z

@greptile

waleedlatif1 · 2026-11-14T05:45:27Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-14T05:45:34Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 28 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

…urrent outside create, and default an unset create value to true

waleedlatif1 · 2026-11-14T05:58:54Z

@greptile

waleedlatif1 · 2026-11-14T05:58:55Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-14T05:59:04Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 30 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

…ith No change in agent tool rows

waleedlatif1 · 2026-11-14T06:02:27Z

@greptile

waleedlatif1 · 2026-11-14T06:02:28Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-14T06:02:34Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 32 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

…create, drop its block-level required, and keep a zero Asana limit for validation

waleedlatif1 · 2026-11-14T06:05:42Z

@greptile

waleedlatif1 · 2026-11-14T06:05:43Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-14T06:05:49Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 33 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-14T06:15:14Z

@greptile

waleedlatif1 · 2026-11-14T06:15:15Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-14T06:15:23Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 33 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 added 4 commits November 13, 2026 20:20

fix(integrations): validate Asana limits, Intercom snooze times, and …

1bfb23f

…Mailchimp template ids, clamp Airtable page size, accept Mailchimp batch arrays, and keep the Mailchimp email type option on update

fix(integrations): resolve the tool-call operation in the QuickBooks,…

18c2ea8

… SAP Concur, Attio, Intercom, Notion, Box, and HubSpot mappers

refactor(integrations): share the Intercom params mapper, reuse the b…

d0715d2

…oolean and JSON input helpers, and drop duplicated test helpers

fix(mailchimp): leave the email type option unchanged when its stored…

82792b3

… value is null

cubic-dev-ai Bot reviewed Nov 14, 2026

View reviewed changes

greptile-apps Bot reviewed Nov 14, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/mailchimp.ts Resolved

vercel Bot deployed to Preview November 14, 2026 05:17

View deployment

fix(integrations): seed the Mailchimp email type option per operation…

0ff6ce7

… and tighten presence checks for Intercom, Airtable, Dropbox, and QuickBooks inputs

vercel Bot temporarily deployed to Preview November 14, 2026 05:24 Inactive

cubic-dev-ai Bot reviewed Nov 14, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/intercom.ts Resolved

greptile-apps Bot reviewed Nov 14, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/mailchimp.ts Resolved

fix(integrations): seed the Mailchimp email type option from the oper…

9c97d3b

…ation's first option and validate the Intercom ticket snooze on tool calls

vercel Bot temporarily deployed to Preview November 14, 2026 05:45 Inactive

greptile-apps Bot reviewed Nov 14, 2026

View reviewed changes

Comment thread apps/sim/tools/mailchimp/create_audience.ts Resolved

cubic-dev-ai Bot reviewed Nov 14, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/mailchimp.ts Resolved

Comment thread apps/sim/tools/mailchimp/create_audience.ts Resolved

Comment thread apps/sim/blocks/blocks/mailchimp.ts Resolved

fix(mailchimp): seed the email type option per operation, keep Keep c…

541acc1

…urrent outside create, and default an unset create value to true

cubic-dev-ai Bot reviewed Nov 14, 2026

View reviewed changes

fix(integrations): lead the Intercom role and Pipedrive deal status w…

6a58f81

…ith No change in agent tool rows

vercel Bot temporarily deployed to Preview November 14, 2026 06:02 Inactive

cubic-dev-ai Bot reviewed Nov 14, 2026

View reviewed changes

fix(integrations): parse the Mailchimp update email type option like …

a529562

…create, drop its block-level required, and keep a zero Asana limit for validation

vercel Bot temporarily deployed to Preview November 14, 2026 06:05 Inactive

cubic-dev-ai Bot reviewed Nov 14, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/asana.ts Resolved

fix(asana): treat a whitespace-only limit field as blank on tool calls

39b9358

vercel Bot temporarily deployed to Preview November 14, 2026 06:15 Inactive

cubic-dev-ai Bot reviewed Nov 14, 2026

View reviewed changes

waleedlatif1 merged commit e4d8673 into staging Nov 14, 2026
83 checks passed

Conversation

waleedlatif1 commented Nov 14, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Nov 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

waleedlatif1 commented Nov 14, 2026

Uh oh!

waleedlatif1 commented Nov 14, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 14, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 14, 2026

Uh oh!

waleedlatif1 commented Nov 14, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 14, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 14, 2026

Uh oh!

waleedlatif1 commented Nov 14, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 14, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Nov 14, 2026

Uh oh!

waleedlatif1 commented Nov 14, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 14, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Nov 14, 2026

Uh oh!

waleedlatif1 commented Nov 14, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 14, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vercel Bot commented Nov 14, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Nov 14, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading