Repository navigation
improvement(search): log the shape of each search and the source, kind, and size of each read - #10042
Merged
Merged
Conversation
…d, and size of each read
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds content-free search and document-read logs.
Reviews (2) · Last reviewed commit: "improvement(search): log a document kind..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sortBy, the date window in days (from the same bounds the providers receive), and per native query its provider, kind, browse mode, and whether it had text, modifiers, a cursor, a project, an account target, or term clauses. AqueryIndexon a provider summary now resolves to a provider, and the shape is logged even when validation rejects the searchother), the full and returned character counts,hasMore, and whether it continued an earlier window, plus a provider summary with the read's request waterfall and stages. MCP reads log assurface: mcp; a copilot read joins its tool call's traceprovider_retryable/provider_errorfor read failures, or the existing network reasons), including when an outer tool call turns the error into a result.LiveReadErrorreports its class throughdiagnosticCodelikeNativeSearchErrorin:#namechannel lookup concluded (exists, missing, unresolved, lookup failed)Type of Change
Testing
lib/knowledge/search,lib/sim-search/live,lib/knowledge/mcp, and the copilot knowledge tools suites pass (631 tests);bun run lintcleanChecklist
test-auditauthoring gate)