feat(code): cli sandboxes, enterprise timeouts, secrets projections, resolver lift, workflow exec cancellations by icecrasher321 · Pull Request #6247 · simstudioai/sim

icecrasher321 · 2026-08-04T08:23:20Z

Summary

Allow CLIs in Sandboxes (with 25 managed CLIs out of the box)
Add Shell as supported language in function block
Enterprise metadata can set custom timeouts now
Resolver lifted to be central compiler adhering to secrets mgmt policies and applying across the board
Workflow execution cancellations to cancel trigger dev side too

Type of Change

New feature

Testing

Tested manually with @Sg312

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…resolver lift

…lver # Conflicts: # apps/sim/components/settings/navigation.test.ts # apps/sim/components/settings/navigation.ts # apps/sim/providers/index.test.ts

gitguardian · 2026-08-04T08:23:26Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
35640005	Triggered	Generic Password	`1a7c79b`	apps/desktop/src/main/browser-import/import-service.test.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

vercel · 2026-08-04T08:23:26Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview	Aug 6, 2026 2:17am

cursor · 2026-08-04T08:23:37Z

PR Summary

High Risk
Changes touch authentication-adjacent secret handling, model-bound data projection, remote sandbox supply chain, and distributed execution/cancellation across Trigger.dev and cleanup cron paths—a broad, security-sensitive surface with many integration points.

Overview
This PR expands remote Function sandboxes with Shell as a language, Debian system packages, and a curated managed CLI catalog (pinned vendor artifacts with checksum-verified server recipes and content-addressed image identity). Docs and agent skills describe how to add CLIs and configure dedicated E2B/Daytona Function bases separately from Mothership shell images.

Secrets and code execution move behind a shared code-placeholder compiler for JavaScript, Python, and Shell: {{KEY}} is bound at the execution boundary instead of pasted into source, with Shell quote/heredoc-aware lowering. Tool and Function paths add opt-in provenance (modelInput projection, opaqueModelInput rejection, secretProvenance for durable sinks) so model-visible and persisted data fail closed without blanket sanitizing third-party API results. A new CI check audits tool request transport boundaries.

Runtime policy: Enterprise workspaces can raise async workflow timeouts up to seven days; async API callers may shorten a run via X-Execution-Timeout-Seconds (never extend policy). Stale execution cleanup respects executionDeadlineAt, uses batched FOR UPDATE SKIP LOCKED pages, and aligns async-job failure messages with per-job max duration. Workflow cancellation is extended so background Trigger.dev work is cancelled alongside in-app execution state.

Smaller contract fixes include upload receipt tokens on batch presigned URLs, distinct execution attachment keys for multipart uploads, Azure multipart completion passing uploadId, and storage CORS/header docs for create-only uploads.

^{Reviewed by Cursor Bugbot for commit 05e6447. Configure here.}

icecrasher321 · 2026-08-04T08:27:03Z

@greptile

greptile-apps · 2026-08-04T08:30:45Z

Greptile Summary

This PR centralizes execution-time placeholder and secret handling while expanding sandbox, timeout, and cancellation capabilities.

Adds curated managed CLIs and Shell execution to Function sandboxes.
Adds configurable Enterprise asynchronous execution timeouts and exposes per-request timeout controls through the SDKs.
Extends cancellation across local, database-backed, Trigger.dev, resumed, and grouped workflow executions.
Projects resolved secrets out of traces and model-visible tool results.
Updates database schema, API contracts, documentation, UI configuration, and tests for the new behavior.

Confidence Score: 5/5

The PR appears safe to merge within the scope of this follow-up review.

No blocking failure remains in the eligible follow-up review scope.

Important Files Changed

Filename	Overview
apps/sim/executor/variables/resolver.ts	Centralizes code-context resolution while preserving environment placeholders for execution-boundary compilation.
apps/sim/lib/execution/code-placeholders/index.ts	Introduces the shared JavaScript, Python, and Shell placeholder-compilation boundary.
apps/sim/lib/execution/remote-sandbox/cli-tools.server.ts	Defines pinned, checksum-verified server-side installation recipes for managed sandbox CLIs.
apps/sim/lib/billing/execution-timeout-defaults.ts	Resolves plan and Enterprise-specific execution timeout policies.
apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.ts	Coordinates durable cancellation state, backend job cancellation, local aborts, resumed executions, and terminal event publication.
apps/sim/lib/core/async-jobs/backends/trigger-dev.ts	Adds execution-scoped Trigger.dev cancellation using tags and payload verification.
packages/db/schema.ts	Adds persisted metadata supporting configurable Enterprise execution limits and related sandbox behavior.

Sequence Diagram

sequenceDiagram
  participant Client
  participant API as Execution API
  participant Policy as Timeout Policy
  participant Queue as Async Backend
  participant Executor
  participant Sandbox
  participant Projection as Secret Projection

  Client->>API: Start workflow
  API->>Policy: Resolve account and request timeout
  Policy-->>API: Effective deadline
  API->>Queue: Enqueue execution with deadline
  Queue->>Executor: Run workflow
  Executor->>Sandbox: Execute Function or Shell with managed CLIs
  Sandbox-->>Executor: Block output
  Executor->>Projection: Sanitize traces and model-visible output
  Projection-->>Client: Stream projected result
  Client->>API: Cancel execution
  API->>Queue: Cancel queued or running job
  API->>Executor: Signal local or resumed execution

_{Reviews (14): Last reviewed commit: "run from block ui disabling" | Re-trigger Greptile}

icecrasher321 · 2026-08-04T09:19:51Z

@greptile

icecrasher321 · 2026-08-04T09:19:58Z

@cursor review

icecrasher321 · 2026-08-04T10:13:16Z

@greptile

icecrasher321 · 2026-08-04T10:13:23Z

@cursor review

icecrasher321 · 2026-08-04T10:26:38Z

@greptile

icecrasher321 · 2026-08-04T10:26:44Z

@cursor review

…lver # Conflicts: # apps/docs/content/docs/en/workflows/blocks/function.mdx # apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/code/code.tsx # apps/sim/lib/copilot/request/tools/executor.test.ts # apps/sim/tools/generated/tool-metadata.ts

icecrasher321 · 2026-08-05T23:08:20Z

bugbot run

…lver # Conflicts: # packages/db/migrations/meta/0282_snapshot.json # packages/db/migrations/meta/_journal.json

…lver # Conflicts: # apps/sim/lib/copilot/tools/handlers/materialize-file.test.ts # apps/sim/lib/copilot/tools/handlers/materialize-file.ts

icecrasher321 · 2026-08-06T02:03:21Z

@greptile

icecrasher321 · 2026-08-06T02:03:25Z

@cursor review

greptile-apps · 2026-08-06T02:03:28Z

Too many files changed for review (826 files, 500 file limit).

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit b6109c4. Configure here.}

icecrasher321 · 2026-08-06T02:11:47Z

@greptile

icecrasher321 · 2026-08-06T02:11:51Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 05e6447. Configure here.}

…ema (#6323) createTableWriteProvenanceTargets (added in #6247) required every submitted column to translate to exactly one storage id and threw otherwise. The wire translator has always dropped keys naming no column in the schema, so any internal-JWT write carrying such a key threw an uncaught error and surfaced as a 500 — where the same write previously succeeded, since the write path drops the column identically. Give a dropped column a null column id instead of throwing. It still gets a target, so the bundle completeness check that pairs one selection per submitted column is unchanged, but no provenance is recorded for a value that is never stored.

…ion (#6705) Condition expressions pasted every environment variable value into the expression as source. Block references in the same expression go through a proper escape and get quoted; env vars went through neither. That left three defects: - A bare string placeholder was a SyntaxError. `{{NAME}} === 'alice'` resolved to `alice === 'alice'`, so the form the Function block docs recommend could not be used here at all. - Ordinary data broke the block. An apostrophe (`O'Brien`) or a newline in a legitimate value produced unparseable source and failed the run. - The quoted form was injectable. A value of `x' || true || '` turned `'{{NAME}}' === 'bob'` into `'x' || true || '' === 'bob'`, forging a true branch out of a comparison that should be false. Inline only structurally inert literals — numbers, booleans, and null, with optional space/tab padding. Every other value keeps its `{{NAME}}` placeholder and is bound as a string by the execution-boundary compiler, the same one Function blocks and Custom Tools already use. Legacy outcomes are preserved. `{{COUNT}} === 3` and `{{ENABLED}} === true` still compare as literals, and an embedded `"Bearer {{API_KEY}}"` still compares equal — now via compiled concatenation rather than a pasted value. Padding is admitted rather than trimmed so the inlined text stays byte-identical to the stored value, which is what keeps a padded number correct both bare and quoted. A resolved secret also no longer travels to the execution boundary inside the condition source. The one deliberate behavior change: a value whose text is itself a quoted JS literal (a secret stored as `'foo'`, a plausible workaround for the bare-string SyntaxError) now compares as the 5-character string rather than as source. That form is the injectable one, so it cannot be kept. Docs: state the placeholder type contract, which was described mechanically but never in terms of what a reader gets. `{{KEY}}` in Function and Custom Tool code always evaluates to a string, so a bare `if ({{FLAG}})` is always true and a list has to be stored as JSON. This is what a customer hit after the resolver lift in #6247 moved Function blocks off source inlining. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

icecrasher321 added 2 commits August 4, 2026 01:07

feat(code): cli sandboxes, enterprise timeouts, secrets projections, …

66b25d3

…resolver lift

Merge remote-tracking branch 'origin/staging' into feat/func-cli-reso…

1a7c79b

…lver # Conflicts: # apps/sim/components/settings/navigation.test.ts # apps/sim/components/settings/navigation.ts # apps/sim/providers/index.test.ts

icecrasher321 requested a review from a team as a code owner August 4, 2026 08:23

vercel Bot deployed to Preview August 4, 2026 08:28 View deployment

cursor Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread apps/sim/app/api/cron/cleanup-stale-executions/route.ts

github-advanced-security AI found potential problems Aug 4, 2026

View reviewed changes

Comment thread apps/sim/lib/execution/code-placeholders/javascript.ts Fixed

fix(execution): harden compatibility and secret diagnostics

9661638

vercel Bot temporarily deployed to Preview August 4, 2026 09:19 Inactive

cursor Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread apps/sim/app/api/cron/cleanup-stale-executions/route.ts

Comment thread apps/sim/app/api/cron/cleanup-stale-executions/route.ts Outdated

fix(execution): harden generated JavaScript literals

78c5e8b

vercel Bot temporarily deployed to Preview August 4, 2026 09:37 Inactive

fix(execution): align timeout cleanup semantics

3ff0dba

vercel Bot temporarily deployed to Preview August 4, 2026 10:11 Inactive

cursor Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread apps/sim/app/api/cron/cleanup-stale-executions/route.ts Outdated

fix(tables): decouple stale job cleanup

d8f777e

vercel Bot temporarily deployed to Preview August 4, 2026 10:26 Inactive

cursor Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread apps/sim/app/api/cron/cleanup-stale-executions/route.ts

fix(execution): drain stale workflow backlog

e3f33d1

vercel Bot temporarily deployed to Preview August 4, 2026 10:45 Inactive

vercel Bot deployed to Preview August 5, 2026 22:23 View deployment

fix

7636c7d

vercel Bot temporarily deployed to Preview August 5, 2026 23:05 Inactive

cursor Bot reviewed Aug 5, 2026

View reviewed changes

Comment thread apps/sim/app/api/cron/cleanup-stale-executions/route.ts Outdated

add provenance linters

6e5c8a1

vercel Bot deployed to Preview August 6, 2026 00:17 View deployment

icecrasher321 added 2 commits August 5, 2026 18:01

Merge remote-tracking branch 'origin/staging' into feat/func-cli-reso…

2d935a0

…lver # Conflicts: # packages/db/migrations/meta/0282_snapshot.json # packages/db/migrations/meta/_journal.json

fix: address review and compatibility regressions

5c58c02

vercel Bot deployed to Preview August 6, 2026 02:01 View deployment

Merge remote-tracking branch 'origin/staging' into feat/func-cli-reso…

b6109c4

…lver # Conflicts: # apps/sim/lib/copilot/tools/handlers/materialize-file.test.ts # apps/sim/lib/copilot/tools/handlers/materialize-file.ts

vercel Bot temporarily deployed to Preview August 6, 2026 02:02 Inactive

cursor Bot reviewed Aug 6, 2026

View reviewed changes

fix: make tool boundary audit Bun 1.3 compatible

05e6447

vercel Bot deployed to Preview August 6, 2026 02:17 View deployment

cursor Bot reviewed Aug 6, 2026

View reviewed changes

icecrasher321 merged commit 117fe31 into staging Aug 6, 2026
28 of 29 checks passed

waleedlatif1 deleted the feat/func-cli-resolver branch August 6, 2026 02:26

mzxchandra mentioned this pull request Aug 6, 2026

feat(embeddings): multi-provider Embeddings block on a shared core #6317

Merged

This was referenced Aug 6, 2026

v0.7.59: secrets obfuscation, providers timeout standardization, cli sandboxes, sso fixes #6318

Merged

fix(tables): stop row writes 500ing on a column outside the table schema #6323

Merged

icecrasher321 mentioned this pull request Aug 14, 2026

fix(condition): stop a secret value from breaking or forging a condition #6705

Merged

5 tasks

Uh oh!

Conversation

icecrasher321 commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

gitguardian Bot commented Aug 4, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

vercel Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

icecrasher321 commented Aug 4, 2026

Uh oh!

Uh oh!

greptile-apps Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

icecrasher321 commented Aug 4, 2026

Uh oh!

icecrasher321 commented Aug 4, 2026

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Aug 4, 2026

Uh oh!

icecrasher321 commented Aug 4, 2026

Uh oh!

Uh oh!

icecrasher321 commented Aug 4, 2026

Uh oh!

icecrasher321 commented Aug 4, 2026

Uh oh!

Uh oh!

icecrasher321 commented Aug 5, 2026

Uh oh!

Uh oh!

icecrasher321 commented Aug 6, 2026

Uh oh!

icecrasher321 commented Aug 6, 2026

Uh oh!

greptile-apps Bot commented Aug 6, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

icecrasher321 commented Aug 6, 2026

Uh oh!

icecrasher321 commented Aug 6, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

icecrasher321 commented Aug 4, 2026 •

edited

Loading

vercel Bot commented Aug 4, 2026 •

edited

Loading

cursor Bot commented Aug 4, 2026 •

edited

Loading

greptile-apps Bot commented Aug 4, 2026 •

edited

Loading