fix(forking): hide satisfied dependent configuration - #6723
fix(forking): hide satisfied dependent configuration#6723icecrasher321 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview When the parent mapping is unchanged and stored values are already valid, satisfied required and optional dependents stay hidden; workflows that only use the resource with nothing to configure still appear in a muted “nothing to configure there” note. If a child still needs a value, upstream provider fields in the same block are shown too so the user can see and change the scoping context. Re-picking a provider now clears every transitive descendant in-session (empty overrides), not just direct children, so stale stored IDs do not leak into the sync payload after a parent in the chain changes. Dependent selector context during collection now respects persisted canonical modes (e.g. advanced Reviewed by Cursor Bugbot for commit c761851. Configure here. |
Greptile SummaryThe PR reduces workspace-fork configuration noise while preserving selectors needed to configure required dependent chains.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/ee/workspace-forking/components/fork-sync/dependent-value.ts | Adds actionable-field classification and transitive context-provider expansion. |
| apps/sim/ee/workspace-forking/components/fork-sync/fork-sync-view.tsx | Filters rendered dependent selectors per mapping state while preserving workflow usage grouping. |
| apps/sim/ee/workspace-forking/components/fork-sync/dependent-value.test.ts | Covers visibility rules and direct and transitive provider inclusion. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Dependent field] --> B{Parent resolved?}
B -- No --> H[Hide selector]
B -- Yes --> C{Parent changed or copied?}
C -- Yes --> S[Show selector]
C -- No --> D{Required value missing?}
D -- Yes --> S
D -- No --> H
S --> P[Include transitive context providers]
Reviews (2): Last reviewed commit: "fix(forking): keep dependent chains conf..." | Re-trigger Greptile
|
bugbot run |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c761851. Configure here.
Summary
Type of Change
Testing
bun run type-checkbun run lintbun run check:auditsbun run apps/sim/scripts/check-block-registry.ts origin/stagingChecklist