fix(provenance): stop requiring a projection of roots no model sees - #6981
Conversation
A secretProvenance selection is the opposite mechanism to a projected model input: the value reaches an internal API unchanged, with its provenance alongside it in the private bundle, precisely so nothing has to be substituted. selectBlockBoundaryPaths marked those roots required to project anyway. That made a projection failure fatal for tools with no way to project. createStructuredModelProjection rescues only a mode: 'project' tool with an applyProjected, so for the twenty-odd secretProvenance-only tools it returns undefined on its first check. table_insert_row declares no modelInput at all and posts row data to the table API; when the Table block's params threw on its projected data the whole run's registry latched, costing provenance for every later boundary — including the table write that prompted it, whose rows were then stored unknown and re-reported on every later read. Track those paths, require none of them. A root is required to project when a model will see it, which is what modelInput declares. Also separate a crossing that carried no provenance from one that was rejected, so a run that failed before producing any stops reporting a by-design state as an originating fault; and carry the first guard's location into the diagnostics a refusal reports, so a downstream reporter names where rather than only what.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview That latch was fatal for bundle-only tools such as Also distinguishes a crossing with no provenance ( Reviewed by Cursor Bugbot for commit 40f8761. Configure here. |
Greptile SummaryThis PR separates private provenance selections from model-input projection requirements and improves provenance diagnostics.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/executor/handlers/generic/generic-handler.ts | Limits required projection roots to declared model inputs while continuing to track private provenance paths. |
| apps/sim/executor/utils/resolved-secret-projection-refusal.ts | Adds nested originating-guard detail to projection-refusal diagnostics. |
| apps/sim/executor/utils/resolved-secret-trace-registry.ts | Adds absent-crossing classification and propagates incompleteness detail through registry diagnostics. |
Reviews (2): Last reviewed commit: "fix(provenance): report where the guard ..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The registry retained the first guard's location, but the refusal reporter copies named fields out of the diagnostics and never picked it up — so the line an operator actually reads when a projection is refused still named only the reason. Nested rather than spread flat: the guard's `inputPath` names where it tripped and the refusal's names where the refusal happened, which differ whenever a latch travels, so flattening would overwrite one with the other.
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 40f8761. Configure here.
1 participant
Summary
secretProvenanceselection is the opposite mechanism to a projected model input: the value reaches an internal API unchanged, with its provenance alongside it in the private bundle, precisely so nothing has to be substituted.selectBlockBoundaryPathsmarked those roots required-to-project anyway.createStructuredModelProjectionrescues only amode: 'project'tool with anapplyProjected, so for the ~21secretProvenance-only tools (memory, file, knowledge, all the table tools) it returnsundefinedon its first check.table_insert_rowdeclares nomodelInputat all — nothing on that path reaches a model.paramsthrew on its projecteddata, the whole run's registry latched, and every later boundary in that run lost provenance — including the table write that prompted it, whose rows were then storedunknownand re-reported on every subsequent read.modelInputdeclares.ModelInputProvenanceline had no tool field at all.Type of Change
Testing
Tested manually.
bun run lint, all 24 CI audits, and type-check pass. 4,459 tests pass across the executor, provenance, table, and secret-provenance suites, including a regression test that a bundle-only tool keeps vouching when its blockparamsthrows on projected inputs — verified to fail against the previous behaviour.Note for review: the reproduction test makes
paramsthrow on any projected input rather than replicating the exact JSON shape that breaks in prod.prepareResolvedSecretProjectedInputspreserves JSON grammar and substitutes inside it, so the common case parses fine; which shape breaks isn't known and doesn't change the invariant under test — a bundle-only tool must not latch the registry when it cannot project.Checklist