fix(vllm): support LM Studio endpoints - #7036
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Runtime: Introduces Docker: Docs cover LM Studio setup, env var wording, and troubleshooting when requests wrongly route to Ollama if models aren’t discovered via the Reviewed by Cursor Bugbot for commit e5a7cdc. Configure here. |
Greptile SummaryThis PR adds LM Studio support to the existing vLLM integration and completes the fixes requested in the previous URL-handling threads.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the current code fixes both previously reported URL-handling issues by parsing pathname components safely and keeping normalization within the graceful models-route error boundary.
|
| Filename | Overview |
|---|---|
| apps/sim/providers/openai-compat/base-url.ts | Parses endpoint URLs, rejects query and fragment components, and normalizes only the pathname to a single /v1 API base. |
| apps/sim/app/api/providers/vllm/models/route.ts | Uses shared URL normalization within the existing graceful error boundary before requesting the models endpoint. |
| apps/sim/providers/vllm/index.ts | Reuses normalized API bases for discovery and inference while preserving endpoint validation and pinned-fetch behavior. |
| docker-compose.ollama.yml | Optionally loads the adjacent .env file into the Sim application service so local-provider configuration reaches the container. |
Reviews (3): Last reviewed commit: "fix(vllm): guard discovery URL validatio..." | Re-trigger Greptile
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1505233. Configure here.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e5a7cdc. Configure here.

Summary
Type of Change
Testing
Checklist