feat(tables): confirm view deletion

[j15z]

Summary

• Add a confirmation modal before deleting a saved table view
• Cover cancel and confirm paths with view-menu tests

Type of Change

• Improvement

Testing

• bunx vitest run 'app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.test.tsx' (6 passed)
• bun run lint
• bun run apps/sim/scripts/check-block-registry.ts origin/staging
• bun run check:audits
• bun run docs-manifest:check

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 24, 2026 7:09pm

[cursor]

PR Summary

Low Risk
UI-only guard using the existing confirmation modal pattern; no API or persistence logic changes beyond deferring the existing delete callback.

Overview
Deleting a saved table view from the Views menu no longer runs immediately. The delete action now opens a ChipConfirmModal that names the view and warns that the action cannot be undone; onDelete is only called after the user confirms.

The menu still closes when delete is chosen (same as rename), and default views remain undeletable. A new test exercises cancel (no delete) and confirm (delete with the correct view id).

^{Reviewed by Cursor Bugbot for commit 30e7dcd. Bugbot is set up for automated code reviews on this repo. Configure here.}

[greptile-apps]

Greptile Summary

The PR adds a confirmation modal before a saved table view is deleted and extends the component tests to cover both cancellation and confirmation.

• Defers the existing deletion callback until explicit confirmation.
• Displays the selected view name and irreversible-action warning.
• Verifies that cancellation does not delete and confirmation passes the expected view ID.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule issues identified.

The new modal defers deletion until confirmation, clears its target on cancellation or completion, and the tests cover both user paths with the expected callback behavior.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.tsx	Adds controlled delete-target state and a confirmation modal while preserving the existing deletion callback contract.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.test.tsx	Adds focused coverage for opening, cancelling, reopening, and confirming saved-view deletion.

_{Reviews (1): Last reviewed commit: "feat(tables): confirm view deletion" | Re-trigger Greptile}