feat(oracle-epm-fccs): add Financial Consolidation and Close integration - #7500
BillLeoutsakosvl346 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@greptile-apps please review this PR. The approved 40-action integration uses one tool definition and one internal operation file per action, plus scoped tests and registrations; please review despite the 100-file automatic-review limit. |
Greptile SummaryThis PR adds a complete Oracle EPM Financial Consolidation and Close integration on top of the existing Oracle EPM foundation.
Confidence Score: 5/5The PR appears safe to merge; the current head addresses both previous findings without introducing a new actionable defect. Manual download and delete now scan the byte-bounded inventory independently of the picker count while retaining EXTERNAL-only validation, and uploads now use a single bounded buffer rather than retaining chunks and concatenating another full payload. Both previous threads were manually resolved after these fixes, and no new correctness, security, or repository-rule violation remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/internal/oracle-epm-fccs/files.ts | Implements bounded external-file lookup, single-buffer uploads, and correctly categorized file-limit/input errors. |
| apps/sim/lib/internal/oracle-epm-fccs/execute-tool.ts | Dispatches all FCCS operations and maps caller, provider, and transport failures to appropriate HTTP statuses. |
| apps/sim/lib/internal/oracle-epm-fccs/schemas.ts | Defines strict FCCS request and response projections, including documented percentage cells and separate bounded file-list versus manual-lookup schemas. |
| apps/sim/lib/internal/oracle-epm-fccs/links.ts | Binds returned diagnostic links to the expected application and job after foundation route validation. |
| apps/sim/lib/selectors/manifest.ts | Ensures the configured-job selector waits for either operation-derived or explicitly selected job-family context. |
| apps/sim/blocks/blocks/oracle_epm_fccs.ts | Defines the FCCS block’s operations, inputs, selectors, outputs, and workflow presentation. |
| apps/docs/content/docs/integrations/oracle_epm_fccs.mdx | Documents authentication, supported FCCS boundaries, response limits, manual fallbacks, and all integration actions. |
Sequence Diagram
sequenceDiagram
participant W as FCCS Workflow Block
participant T as Internal FCCS Tool
participant F as Oracle EPM Foundation
participant O as Oracle FCCS
participant S as Sim File Storage
W->>T: Validated operation input
T->>F: Credential-bound request
F->>F: Validate destination and declared route
F->>O: Authenticated FCCS REST request
O-->>F: Bounded response or job link
F-->>T: Validated provider response
alt Asynchronous job
T-->>W: Normalized jobId and status
W->>T: Wait/Get Job
T->>F: Bounded cancellable polling
F->>O: Read job status
O-->>F: Terminal status and diagnostics
F-->>T: Validated result
else File download
T->>F: Validate external repository entry
F->>O: Download bounded file
O-->>F: Binary stream
F->>S: Store execution-scoped UserFile
S-->>T: UserFile reference
end
T-->>W: Projected FCCS output
Reviews (2): Last reviewed commit: "fix(oracle-epm-fccs): address integratio..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 119 files
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Re-trigger cubic
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
7d67b10 to
5bb3a32
Compare
Preserve FCCS and current registrations, retain foundation deletions and the moved Mothership docs manifest, and regenerate canonical tool and integration projections. Adapt FCCS selector preparation to authorized organization service accounts while preserving workspace credential checks. Canonical write generators completed. Tests, typechecks, lint, audits, builds, and CI waits were omitted as requested.
Summary
feat/oracle-epm-foundation, base9ec1be01aac6fac1bbacafe14e93f53188f45c1b). No foundation or shared runtime behavior changes.Type of Change
Testing
7d67b104b96bdfd140d6dfd5de6d08988eef8b5f: Test and Build CI passed, including app build, typecheck, lint/audits, and all test shards. No further local builds/typechecks/tests were run after the author's request. No live Oracle tenant credentials were available.API boundaries
Implementation notes
Review status
7d67b104b96bdfd140d6dfd5de6d08988eef8b5f.Checklist