Skip to content

fix(mothership): strip presentation activity from desktop-authorized tool args - #8277

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/browser-tool-strip-activity
Sep 24, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/browser-tool-strip-activity

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Electron executes browser and terminal tools with the server-persisted args returned by /api/desktop/tool/authorize, which still carried the worker's presentation-only activity field; browser_fill_form rejects any key other than fields, so it failed on nearly every call once activity became required (mothership dd30087)
  • The authorize route now omits activity from the args it returns, matching the server-side executor; Sim still reads it from the frame for row grouping
  • Companion to simstudioai/mothership#517 / Fix/normalized tables type bug #521; should ship with or before that release

Type of Change

  • Bug fix

Testing

  • Added a regression test in authorize/route.test.ts (fails without the fix); file passes 12/12
  • bun run check:audits (49 audits) and biome pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 11:04pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previously identified execution path now receives arguments without presentation activity.

Summary

The PR moves removal of presentation-only activity from the renderer to the desktop authorization response, so Electron receives executable arguments without that field.

  • Adds a route regression test for browser_fill_form.
  • Reverts the renderer-side stripping and its test.

Reviews (2) · Last reviewed commit: "fix(mothership): strip activity from des..."

Comment thread apps/sim/lib/mothership/tools/client/browser-tool-execution.ts Outdated
@waleedlatif1 waleedlatif1 changed the title fix(mothership): strip presentation activity before desktop browser dispatch fix(mothership): strip presentation activity from desktop-authorized tool args Sep 24, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit cbffe90 into staging Sep 24, 2026
25 of 26 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/browser-tool-strip-activity branch September 24, 2026 23:09

This branch was previously deployed

1 inactive deployment
Preview — 25fb5e4b Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant