Skip to content

improvement(search): accept several same-kind native queries per account and cap oversized read limits - #8407

Open
waleedlatif1 wants to merge 7 commits into
stagingfrom
improvement/search-tool-input-tolerance
Open

improvement(search): accept several same-kind native queries per account and cap oversized read limits#8407
waleedlatif1 wants to merge 7 commits into
stagingfrom
improvement/search-tool-input-tolerance

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Search accepts several native queries of the same kind for one GitHub, GitLab, or HubSpot account. Each already runs as its own query with its own cursor and is rank-fused, and the per-account cap still bounds the provider calls. A query with no kind still cannot share an account with kinded ones, since it fans out across every kind
  • read_document caps a limit above 8 to 8 instead of refusing it. The server already returns at most 8 chunks, and the model still sees the 1–8 range
  • On a live-search benchmark, a quarter of Assistant turns (61 of 245) lost at least one model round to a refused tool call. These two rules accounted for 60 of the 94 refusals. Each refusal costs a full model round, about 2–3 s, before the retry
  • Companion worker PR syncs the generated contract

Type of Change

  • Improvement

Testing

  • workspace-search.test.ts: a read_document call with limit 9 succeeds and returns 8 chunks. This test fails on the previous code, which refused the call
  • mothership-assistant-tools.test.ts: a query with no kind alongside kinded queries on one account is still refused
  • bun run lint, bun run check:audits (52 audits), type-check, and the contracts, live-search, and knowledge tool suites pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 29, 2026 8:16am UTC

Request Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 29, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Changes search query validation rules and document read limits.

The PR appears safe to merge; no new actionable failure remains.

Summary

The PR allows distinct same-kind native queries within the existing per-account cap and caps oversized read_document limits at eight chunks.

  • Updates the model-facing search guidance and generated tool contracts.
  • Tests the capped read through the tool result. All previous Greptile threads are resolved.

Reviews (7) · Last reviewed commit: "test(search): keep only the refusal the ..."

greptile-apps[bot]
greptile-apps Bot reviewed Sep 29, 2026
View reviewed changes
Comment thread apps/sim/lib/api/contracts/mothership-assistant-tools.ts
Comment thread apps/sim/lib/mothership/tools/server/knowledge/workspace-search.test.ts Outdated
@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 29, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

greptile-apps[bot]
greptile-apps Bot reviewed Sep 29, 2026
View reviewed changes
Comment thread apps/sim/lib/api/contracts/mothership-assistant-tools.test.ts Outdated
@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 29, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

greptile-apps[bot]
greptile-apps Bot reviewed Sep 29, 2026
View reviewed changes
Comment thread apps/sim/lib/api/contracts/mothership-assistant-tools.ts Outdated
@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 29, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 29, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/api/contracts/mothership-assistant-tools.ts Outdated
@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 29, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

greptile-apps[bot]
greptile-apps Bot reviewed Sep 29, 2026
View reviewed changes
Comment thread apps/sim/lib/api/contracts/mothership-assistant-tools.test.ts Outdated
@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 29, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — b62b2dc6 Deployed Sep 29, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1