Skip to content

improvement(chat): show live search sources by default - #8419

Merged
waleedlatif1 merged 2 commits into
stagingfrom
improvement/search-sources-live
Sep 29, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
improvement/search-sources-live

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Expand live workspace search activity when source results arrive, then collapse it when the answer starts.
  • Preserve a user's manual disclosure choice.

Type of Change

  • Other: UI improvement

Testing

  • Browser demo using the real activity component and synthetic search results: verified live expansion, answer transition, manual toggles, and unchanged non-search activity.
  • bun run --cwd apps/sim type-check
  • bun run --cwd apps/sim test (focused activity tests, including the new disclosure regression)
  • bun run lint, bun run check:audits (52 audits), and bun run docs-manifest:check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (regression test failed on pre-fix code)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Synthetic browser captures using the real activity component and placeholder source names.

Before — live search stayed collapsed

Live search collapsed before change

During live search — sources expanded automatically
Sources expanded during live search

After the answer starts — activity collapses
Search activity collapsed after answer starts

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 29, 2026 6:11pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Changes default visibility of search results in chat messages.

The PR appears safe to merge; no outstanding findings remain.

Summary

The PR automatically expands live workspace-search sources and collapses them when the answer begins, while preserving manual disclosure choices.

  • Adds a regression test for result arrival, answer transition, source visibility, and manual toggles.

Reviews (3) · Last reviewed commit: "test(chat): cover live search disclosure..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 69326d2 into staging Sep 29, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/search-sources-live branch September 29, 2026 23:28

This branch was previously deployed

1 inactive deployment
Preview — 8688354a Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants