Skip to content

improvement(desktop): surface update actions in a persistent toast - #8421

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/desktop-update-notice
Sep 29, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/desktop-update-notice

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add a persistent, dismissible desktop update toast alongside the Help-menu indicator, with Download update and Restart to update actions.
  • Keep prompts across navigation, distinguish explicit dismissal from toast eviction, and withdraw actions when the updater state changes.
  • Leave the mandatory-update gate in charge of unsupported shells.

Type of Change

  • Improvement

Testing

  • Electron update-notification and updater E2E suites, including JSON reports and light/dark screenshots. Negative controls failed at the intended lifecycle checks, including a red-to-green stack-eviction regression.
  • Existing desktop update hook regression, desktop/app/EMCN type-checks, lint, block-registry check, full check:audits, and docs-manifest check.
  • Fix and rerun the existing password-autofill E2E race: wait for the selected picker to close before reopening it.
  • Cleanup and test-audit review completed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 29, 2026 6:57pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread .github/workflows/desktop-e2e.yml
Comment thread apps/sim/app/_shell/desktop-update-notification.tsx
@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds persistent toast notifications for desktop app updates.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR adds a persistent desktop-update toast, distinguishes explicit dismissal from stack eviction, and extends Electron regression coverage.

  • Update actions remain available across navigation and are withdrawn when updater state changes.
  • The workflow now runs desktop E2E tests for root-layout changes.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Desktop updater state] --> B{Available or ready?}
  B -- No --> C[Withdraw toast]
  B -- Yes --> D{Offer explicitly dismissed?}
  D -- Yes --> E[Keep offer hidden]
  D -- No --> F[Show persistent action toast]
  F --> G[Download or restart]
Loading

Reviews (3) · Last reviewed commit: "fix(desktop): distinguish update toast d..."

Comment thread apps/sim/app/_shell/desktop-update-notification.tsx Outdated
Comment thread .github/workflows/desktop-e2e.yml
Comment thread apps/sim/app/_shell/desktop-update-notification.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/desktop/e2e/fixtures/update-notification.tsx
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 025f2ec into staging Sep 29, 2026
35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/desktop-update-notice branch September 29, 2026 19:07

This branch was successfully deployed

1 active deployment
Preview — fc4aede9 Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant