Skip to content

feat(search): browse Lucid folders and Notion pages - #8579

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/provider-search-discovery
Oct 2, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/provider-search-discovery

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add explicit, bounded Lucid folder and Notion sidebar browsing so discovery does not require invented search keywords. Keep folder navigation separate from readable document references and preserve account authorization on every request.
  • Use advertised, plan-supported Notion modification filters and newest sorting, with conservative candidate dates and exact local timestamp checks. Bind continuations to the caller, account, query, filters, folder and page size.
  • Update query guidance and provider documentation.

Type of Change

  • Feature

Testing

  • Root test gate: 19 workspace tasks passed, including 34,621 app tests and 25 existing skips; all 26 workspace type checks, 58 audits, lint, registry and generator/docs checks passed.
  • 38 real Postgres/Redis and guarded MCP HTTP integration checks passed. Eleven independent guard-removal controls failed as intended; sources restored.
  • Live Lucid root listing, continuation and document reads passed; live Notion private/shared/favorites/recent listing and available continuation/reads passed. Child folders and advanced-plan date filtering are covered by HTTP fixtures, not live account acceptance.
  • Companion worker final model evaluation: 15/15 tool-policy cases and 14/15 semantic cases passed with simulated sources. One answer added unsupported application behavior after correct retrieval; that failure and earlier receipts are retained. Lists remain bounded, and this does not remove provider-side document-read latency.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 2, 2026 7:26pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 17 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/sim-search/live/application.ts
@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds browsing mode to search for Lucid folders and Notion pages.

The changes since the previous review appear safe to merge.

Summary

The PR adds bounded Lucid folder and Notion sidebar browsing, extends continuation binding and Notion date-filter handling, and updates assistant guidance and provider documentation.

  • Lucid folders are returned as navigation references separate from readable documents.
  • Notion browsing uses the connected account’s advertised tools; modification filters and newest sorting are used when supported.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Assistant search request] --> B[Authorize account and select native query]
  B --> C{Provider and mode}
  C -->|Lucid folder| D[List one folder page]
  C -->|Notion sidebar| E[List one sidebar page]
  C -->|Content search| F[Search provider]
  D --> G[Verify readable documents]
  E --> G
  F --> G
  G --> H[Return results, navigation references, and bound continuation]
Loading

Reviews (2) · Last reviewed commit: "fix(search): preserve discovery query bo..."

@greptile-apps

This comment has been minimized.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

The sorted Notion continuation concern does not reproduce. Continuations are supplied through nativeQueries, so inside the native?.cursor branch the parsed native query exists and its query string is defined. A nonempty topical query therefore does not require a listingEndDate. ffb62fb adds real Postgres/Redis + MCP HTTP regressions for a plain first search followed by native cursor continuation, covering both newest and oldest sorting. Both passed on the preceding production code without modifying cursor behavior. Empty date listings continue to retain their anchored bound.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 17 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 44016cd into staging Oct 2, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/provider-search-discovery branch October 2, 2026 19:54

This branch was previously deployed

1 inactive deployment
Preview — ffb62fb8 Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant