fix(integrations): list tools for integrations without an operation dropdown - #8582
Conversation
…ropdown The catalog generator only read operations from a block's own 'operation' dropdown, so single-tool blocks and provider pickers (DuckDuckGo, SMTP, Twilio SMS, Embeddings, ...) emitted zero operations, and Notion v2 lost its dropdown because it spreads NotionBlock.subBlocks instead of the whole config. Resolve operations through same-file subBlocks spreads, and fall back to the block's tools.access ids named from the client-safe tool metadata.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…in the catalog generator
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
scripts/generate-docs.tsemitted zero operations for 17 entries inpackages/deployment-config/src/integrations.json, so their/integrations/<slug>pages listed no tools and their JSON-LD ItemList was empty. There were two causes:subBlocksentry withid: 'operation'. Single-tool blocks like DuckDuckGo, SMTP, Twilio SMS and Google Search don't have one, and neither do provider pickers like Embeddings, so they emitted nothing. These now fall back to the block'stools.accessids. Names and descriptions come from the client-safe tool metadata (apps/sim/tools/generated/tool-metadata.ts), not the executable registry.NotionV2BlockreusessubBlocks: [...NotionBlock.subBlocks, ...]instead of spreading the whole config, so the generator never saw its dropdown. Operations are now resolved through a same-file...XBlock.subBlocksspread when a block has no dropdown of its own and inherits none through a config-level spread.Integrations that already listed operations come out unchanged: the regenerated JSON differs only in
operationsandoperationCounton the 17 entries that were empty, and ordering is unchanged. The docs.mdxpages already built their action sections fromtools.access, so they don't change.Type of Change
Testing
I regenerated with
bun run scripts/generate-docs.tsand diffedintegrations.jsonbefore and after. Only these entries changed. Each went from 0 tools to N:notion_v2)extend_v2)mistral_parse_v3)pulse_v2)reducto_v2)No integration has empty operations any more. These all pass:
bun run docs:check,bun run integration-catalog:check,bun run check:audits,bun run lint,bun run type-check, andscripts/generate-docs.test.ts.Checklist
🤖 Generated with Claude Code