fix(audits): apply browser-runtime rules to @sim/utils; align settings checklist with the standalone description rule - #8591
Merged
Conversation
…s checklist with the standalone description rule
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check:utilsskippedpackages/utils/srcand the allowlisted files for every pattern, sotoSorted/toReversed/toSpliced,useRef(new X()), andh-N w-Nwent unchecked in@sim/utils, which ships to the browserreplacesHelper: true); every other rule, including any added later, applies everywhere by defaultsim-settings-pages.mdchecklist step 1 requiredunified.description, contradicting the paragraph above it that allowsplanes.<plane>.descriptionfor a standalone-only section; step 1 now defers to that paragraphType of Change
Testing
toSortedin apackages/utils/srcfile is flagged; an inline helper primitive there still passesbun run lint,bun run type-check,bun run check:audits(58),docs-manifest:check, block-registry check, rootbun run test(all suites)Checklist
test-auditauthoring gate)🤖 Generated with Claude Code