Skip to content

fix(audits): apply browser-runtime rules to @sim/utils; align settings checklist with the standalone description rule - #8591

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/utils-es2023-and-settings-checklist
Oct 2, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/utils-es2023-and-settings-checklist

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • check:utils skipped packages/utils/src and the allowlisted files for every pattern, so toSorted/toReversed/toSpliced, useRef(new X()), and h-N w-N went unchecked in @sim/utils, which ships to the browser
  • The exemption now covers only the 13 rules that ban re-implementing a helper (replacesHelper: true); every other rule, including any added later, applies everywhere by default
  • sim-settings-pages.md checklist step 1 required unified.description, contradicting the paragraph above it that allows planes.<plane>.description for a standalone-only section; step 1 now defers to that paragraph

Type of Change

  • Bug fix

Testing

  • Probed: toSorted in a packages/utils/src file is flagged; an inline helper primitive there still passes
  • bun run lint, bun run type-check, bun run check:audits (58), docs-manifest:check, block-registry check, root bun run test (all suites)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

…s checklist with the standalone description rule
@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 2, 2026 11:16pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Updates code-style rules and adds enforcement tests.

The PR appears safe to merge; no outstanding or newly introduced actionable issue was identified.

Summary

The PR narrows helper-source exemptions so browser-runtime rules also scan @sim/utils and allowlisted files, adds regression tests, and makes the settings checklist consistent with its description guidance.

Reviews (2) · Last reviewed commit: "test(audits): pin which check:utils rule..."

Comment thread scripts/check-utils-enforcement.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit d3bf864 into staging Oct 2, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/utils-es2023-and-settings-checklist branch October 2, 2026 23:26

This branch was successfully deployed

1 active deployment
Preview — ff6a9171 Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant