improvement(tools): stop exporting tool types used only in their own file - #8597
Merged
Merged
Conversation
…file - Drop `export` from 406 tool types referenced only inside their own types.ts - Delete 27 tool types used nowhere, plus 5 private param types only they referenced - Remove the dead `DataverseResponse` re-export from microsoft_dynamics_365/index.ts - Shrink check-unused-exports baseline by 434 entries; `export const` output schemas untouched
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/sim/tools/*/types.ts, 406interface/typedeclarations used only inside their own file loseexport; 32 used nowhere are deleted (27 baselined plus 5 private types only they referenced), and one dead re-export goes frommicrosoft_dynamics_365/index.ts.interface/typedeclaration, and noconstorfunctionline changes. The*_OUTPUT_PROPERTIESconsts stay exported becausegenerate-docs.tsresolves them byexport const; generated docs are unchanged.check:unused-exportsbaseline shrinks by 434 entries; thetools/*/types.tsbucket now holds only those consts and a few helper functions.Type of Change
Testing
bun run lint,bun run type-check,bun run check:audits(58, incl.docs:checkandcheck:unused-exports),docs-manifest:check, block-registry check, rootbun run testChecklist
test-auditauthoring gate)🤖 Generated with Claude Code