Skip to content

fix(webhooks): check existing path owners before claiming on deploy - #8605

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/webhook-deploy-path-conflict
Oct 3, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/webhook-deploy-path-conflict

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Deploy-time webhook registration now checks for another workflow's live webhook on the same path before claiming it, matching the existing check on the other webhook write paths
  • Conflicts surface as the existing 409 "path already in use" error

Type of Change

  • Bug fix

Testing

  • New registration-store.integration.ts against real Postgres (fails without the fix)
  • lib/webhooks unit tests, lint, type-check, check:audits, full bun run test

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 3, 2026 7:29pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Critical risk] Webhook path ownership validation during deployment.

The PR appears safe to merge; no actionable regression was identified.

Summary

Deploy-time webhook registration now checks existing path owners before claiming a path, including owners represented only by live legacy webhook rows.

  • Adds PostgreSQL integration coverage for conflicting and free paths.
  • Updates the unit-test mock for the new ownership lookup.

Reviews (1) · Last reviewed commit: "fix(webhooks): check existing path owner..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 86fcaf6 into staging Oct 3, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/webhook-deploy-path-conflict branch October 3, 2026 21:16

This branch was previously deployed

1 inactive deployment
Preview — e1f58221 Deployed Oct 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant