Repository navigation
fix(code-placeholders): reject shell arithmetic placeholders - #8628
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$((...)),$[...], and((...))(including arithmeticforheaders) before sandbox execution, where Bash recursively evaluates operand text.let, numeric[[ ... ]]comparisons, array subscripts, integer assignments, and values assigned elsewhere before arithmetic evaluation remain outside this change. The demonstrated path uses environment values available to the shell author; no additional privilege boundary is crossed.Type of Change
Testing
bun run lint,bun run type-check, all 58 repository audits, docs-manifest check, and the staging-based block-registry check passed.executor/execution/executor.test.tscase "does not run a stale branch inside a loop"; all 18 other test tasks passed. The timeout also reproduces with this patch removed on clean staging.Checklist
test-auditauthoring gate)