Repository navigation
Conversation
|
@AYANscyy2 is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8506
The Zoom Delete Recording tool calls two different Zoom endpoints depending on whether
recordingIdis set, and each requires a different scope:DELETE /meetings/{id}/recordings/{recordingId}cloud_recording:delete:recording_fileDELETE /meetings/{id}/recordingscloud_recording:delete:meeting_recordingSim only declared and requested the first scope, so the delete-all path (no recording ID) used a token that Zoom rejects for a missing scope.
Changes
tools/zoom/delete_recording.ts: require both scopeslib/oauth/oauth.ts,lib/oauth/utils.ts: request the new scope at consent and add its description:adminvariant)tools/generated/tool-metadata.tsviabun run tool-metadata:generateNotes
Type of Change
Testing
biome checkclean on changed filesvitest run lib/oauth tools/zoom: 20 files, 294 tests passtool-metadata:generatediff limited to the one Zoom entryChecklist