test(mcp): exercise the real destination check in lifecycle tests

[TheodoreSpeaks]

Summary

• Drop the @/lib/mcp/utils mock from server-lifecycle.test.ts so lifecycle tests run the real isSameMcpServerDestination instead of a copied origin+path comparison that ignored URL credentials
• Add a lifecycle case: a non-admin changing only the credentials embedded in the URL is refused as forbidden
• Follow-up to fix(mcp): treat different URL credentials as a new destination #8656 (Greptile finding; fix(mcp): treat different URL credentials as a new destination #8656 merged before this commit landed)

Type of Change

• Test improvement

Testing

• New case fails against the pre-fix(mcp): treat different URL credentials as a new destination #8656 helper and passes now
• lib/mcp/ suite (346 tests), bun run lint, bun run check:audits (58 audits)

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing (new tests pass the test-audit authoring gate)
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

https://claude.ai/code/session_01JjtPrqVTDboym1WpRzFi11

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 6, 2026 3:36am UTC

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[greptile-apps]

Confidence Score: 5/5

[Low risk] Test file removes mock overrides to use real implementation.

The PR appears safe to merge based on the reviewed test changes.

Summary

The PR removes a copied MCP destination comparator from lifecycle tests, uses the real ID generator, and adds a regression case for a non-admin changing URL credentials.

• The new case exercises the real credential-aware destination guard.
• No new actionable issue was identified.

_{Reviews (2) · Last reviewed commit: "test(mcp): exercise the real destination..."}

[TheodoreSpeaks]

@greptile

[TheodoreSpeaks]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}