Repository navigation
fix(desktop): order inbox items by microsecond persistence time - #8693
Closed
TheodoreSpeaks wants to merge 2 commits into
Closed
TheodoreSpeaks wants to merge 2 commits into
TheodoreSpeaks wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete. |
Collaborator
Author
|
Superseded by #8685, which fixes the same inbox ordering with a |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createdAt.getTime(), which truncates to milliseconds, so calls persisted within the same millisecond tied and fell through to the randomtoolCallId— inbox order was non-deterministiccreated_atas epoch microseconds and merge on that, matching the SQLORDER BYwithin each setexecutor.integration.tsinbox ordering tests ("lists pending calls in persistence order…" and "lists new work however many calls the device is already running")Type of Change
Testing
pendingCallrows 1µs apart inside one millisecond: pre-fix the persistence-order test failed with calls in UUID order; post-fix 28/28 passed in 5 runslib/desktop/application/executor.integration.tsviabun run test:integration: 28/28 passed in 6 consecutive runsbun run lint,bun run check:audits(58 audits),docs-manifest:check, block-registry check pass; rootbun run testgreen apart from 3 local-env-dependent rate-limit/execution-limit tests unrelated to this diffChecklist
test-auditauthoring gate)🤖 Generated with Claude Code
https://claude.ai/code/session_017p4HBhAXFVJRPhrG9DDZU3