fix(ci): stop the detached telemetry flush too, re-signal stragglers on a monotonic clock, and report HTTP E2E failures by route by waleedlatif1 · Pull Request #8706 · simstudioai/sim

waleedlatif1 · 2026-10-07T00:28:13Z

Summary

CI: next dev spawns its telemetry flush detached, in a session of its own, even with telemetry disabled. That process outlived the app's session and wrote .next/dev/trace after stop-session.sh returned. The next app's rm -rf .next/dev could then fail with "Directory not empty", which happened in 5 of 68 recent CI runs.
- Each app now starts as E2E_APP=<name> setsid ..., and every process it spawns inherits that tag.
- stop-session.sh <pid> <name> stops and waits for both the session's members and any tagged process that left the session.
stop-session.sh:
- Times its grace period from /proc/uptime, which is monotonic and not affected by the locale's decimal separator. EPOCHREALTIME is neither.
- Re-signals the session every 0.1s, so a process that joins the session after the first signal is stopped too.
- The header now says why zombies don't count.
Version compare E2E: a request that times out while its body is being read now names its route, the same as a request that never answered.
Desktop inbox E2E: callers that join an executor pull already in flight share it, so a failed pull is logged once instead of once per caller.

Type of Change

Bug fix

Testing

Checked stop-session.sh on Linux; each case left no processes behind:
- a member in its own process group stopped immediately;
- a member that ignores SIGTERM was SIGKILLed at 10s;
- a member that starts a new process when it receives SIGTERM: the new process was stopped within 1s;
- a leader that ignores SIGTERM was SIGKILLed at 10s.
Ran a stop-then-wipe loop on Linux:
- Before this change, Next's detached flush was still running every time stop-session.sh returned (12 of 12 rounds).
- After, it was caught, in its own session, and stopped. No flush was left and nothing wrote under .next afterwards (8 of 8 rounds).
Checked that a tagged process that detaches into its own session and keeps writing is stopped within 1s.
Ran the full HTTP E2E app sequence 3 times on Linux (8 cores, cold .next for each app). Every iteration passed, and all warm-up checks passed.
Typecheck and lint pass.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…t HTTP E2E failures once, by route - stop-session.sh times its grace period from /proc/uptime, which is monotonic and free of the locale's decimal separator, re-signals every 0.1s so a process that joins the session after the first signal is stopped too, and explains why zombies don't count - version compare: a request whose body times out names its route like a request that never answered - desktop inbox: callers that join an executor pull in flight share it, so a failed pull is logged once

vercel · 2026-10-07T00:28:19Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Oct 7, 2026 1:41am UTC

waleedlatif1 · 2026-10-07T00:28:20Z

@greptile

waleedlatif1 · 2026-10-07T00:28:22Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-07T00:28:27Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-07T00:32:13Z

Confidence Score: 5/5

[Medium risk] Adjusts end-to-end test infrastructure and error handling.

The PR appears safe to merge; no actionable new issue was found.

What we checked:

Cleanup calls keep working: All four callers pass a tag matching their app’s launch. No caller still uses the old one-argument call.

Summary

The PR strengthens HTTP E2E cleanup and makes failure logs clearer.

stop-session.sh uses a monotonic clock, repeats signals, and finds detached processes carrying the app’s tag.
All four app launches and cleanup calls use matching tags.
Body-read timeouts name the requested route. Executor pull failures are logged once.
The earlier stack-loss finding is fixed: logger.error receives the original error.

_{Reviews (3) · Last reviewed commit: "fix(ci): also stop the detached telemetr..." · Reviewed by Greptile}

waleedlatif1 · 2026-10-07T00:45:26Z

@greptile

waleedlatif1 · 2026-10-07T00:45:27Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-07T00:45:33Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

…p leaves behind `next dev` spawns its telemetry flush detached, in a session of its own, even with telemetry disabled. That process outlives the app's session and writes .next/dev/trace after stop-session.sh returned, so the next app's `rm -rf .next/dev` could fail with "Directory not empty". Each app now starts under an E2E_APP tag that every process it spawns inherits, and stop-session.sh stops and waits for tagged processes as well as the session's members.

waleedlatif1 · 2026-10-07T01:38:16Z

@greptile

waleedlatif1 · 2026-10-07T01:38:17Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-07T01:38:21Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 4 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai Bot reviewed Oct 7, 2026

View reviewed changes

vercel Bot deployed to Preview October 7, 2026 00:30 View deployment

greptile-apps Bot reviewed Oct 7, 2026

View reviewed changes

Comment thread apps/sim/scripts/test-desktop-inbox-e2e.ts Outdated

fix(e2e): log a failed executor pull with its stack

43bab1f

vercel Bot temporarily deployed to Preview October 7, 2026 00:45 Inactive

cubic-dev-ai Bot reviewed Oct 7, 2026

View reviewed changes

waleedlatif1 changed the title ~~fix(e2e): re-signal session stragglers on a monotonic clock and report HTTP E2E failures once, by route~~ fix(ci): stop the detached telemetry flush too, re-signal stragglers on a monotonic clock, and report HTTP E2E failures by route Oct 7, 2026

cubic-dev-ai Bot reviewed Oct 7, 2026

View reviewed changes

vercel Bot deployed to Preview October 7, 2026 01:41 View deployment

waleedlatif1 merged commit e82689a into staging Oct 7, 2026
34 checks passed

waleedlatif1 deleted the fix/http-e2e-review-nits branch October 7, 2026 02:15

waleedlatif1 mentioned this pull request Oct 7, 2026

v0.9.15: mship improvements, memory improvements, nextjs bump, plane and ramp integrations, outbox hardening #8748

Merged

Conversation

waleedlatif1 commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Oct 7, 2026 •

edited

Loading

vercel Bot commented Oct 7, 2026 •

edited

Loading

greptile-apps Bot commented Oct 7, 2026 •

edited

Loading