Repository navigation
improvement(triggers): move TRIGGER_TYPES to a dependency-free module - #8711
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRIGGER_TYPES/TriggerTypeintolib/workflows/triggers/types.ts, which has no importslib/execution/files.tsonly needed that constant, but importing it fromtriggers.tspulledgetBlock→ the whole block registry (icons, emcn, workflow-renderer) into every Trigger.dev task that touches uploadstriggers.tsimports it instead of defining it (no re-export)Static import graph (esbuild metafile, Trigger externals), block registry now unreachable from all three:
knowledge-connector-sync: 4,876 → 3,716 modulesknowledge-process-document: 4,529 → 3,367 modulesworkspace-file-search-dispatch: 3,375 → 1,708 modules (runs on small-1x, 512 MB)Type of Change
Testing
triggers.ts(8 files, 133 tests)bun run lint,bun run type-check,bun run check:audits(incl.check:file-names,check:unused-exports,check:tool-registry-boundary) — greenChecklist
test-auditauthoring gate)