test(desktop): pin the journal snapshot before recovery, keep start going when the journal cannot load, and run tmux in the canary E2E

[waleedlatif1]

Summary

Review follow-ups from #8737 and #8733.

• The journal-snapshot test now fails when the snapshot is taken after recovery.
  • Recovery hands its deliveries off without waiting for them, so the journal still held the result when recover() returned. A snapshot taken after recovery therefore stayed green.
  • The test now makes recovery return only once Sim has the result and the journal no longer holds it.
• A journal load that throws no longer stops the executor from starting.
  • The pending-results snapshot catches a rejected journal.load(), logs it, and counts the journal as holding none.
  • Without that, start() would never reach recovery or the inbox.
• The electron@latest canary job now installs tmux. Before, its terminal-cancel tmux scenarios skipped silently.
• Not changed:
  • forget dropping the call index entry: a ledger test already pins it. It has no other observable effect: after forget, the record file is gone, so a late advance finds nothing and does nothing.
  • A plain-shell user command in the cookie test: sign-out closes every plain shell by design. A user's plain-shell command is checked against Stop, and the user's tmux pane against every path.

Type of Change

• Test coverage

Testing

• Desktop executor tests: 88/88.
• Red checks: each of these fails the service tests in 3 of 3 runs:
  • moving the snapshot after recover();
  • removing the snapshot;
  • removing the .catch.
• EC2 gate: green.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic-dev-ai review this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 7, 2026 9:47am UTC

[cubic-dev-ai]

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 3 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

[cubic-dev-ai]

All reported issues were addressed across 3 files

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Turn on auto-fix | Re-trigger cubic</sub>

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Changes how the desktop app handles journal load failures.

The PR appears safe to merge.

Summary

The PR strengthens the journal recovery test, lets startup continue when the journal snapshot cannot load, and installs tmux in the Electron canary job.

• The latest change waits until the journal is empty before checking pendingResults().
• The previous unnumbered finding is fully addressed: the early check and mock-call assertion are gone.
• No new actionable issues were found.

_{Reviews (2) · Last reviewed commit: "test(desktop): wait for the journal to e..." · Reviewed by Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 3 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}