Repository navigation
fix(desktop): linear path trim, prompt Stop between keystrokes, clear a closed session's input marker - #8753
Merged
Merged
Conversation
… a closed session's input marker
Collaborator
Author
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three review findings from #8748 in the desktop app and bridge.
/\/+$/is quadratic on a long run of/that stops short of the end. Moved the backward-scanstripTrailingSlashesfromsim-cliinto@sim/utils/stringand used it in the bridge's grep, plus the two sibling sites in the desktop's local filesystem service (grep authorization and globpathPrefix), which run the same model-supplied path on the main process.settleBetweenKeystrokes()ignored the Stop signal, sopressKeys/typeagainst a program that redraws constantly could hold Stop for ~1.15 s. It now takes the signal, sleeps withinterruptibleSleep, and leaves the loop on abort. The existing post-settle guard still keeps any further input from being sent.closeLiveTabs()didn't clearuserIntervention, so aftercloseSession()reset tab ids, a new tab "1" inherited the old marker and the agent waited up to 4 s. Cleared alongside the other per-tab flags.Type of Change
Testing
Each fix has a regression test, checked red against the original source:
xgrep path takes 23.6 s before, <1 s after; trailing-slash path still resolves to the same folderpathPrefixtakes 40.9 s before, <1 s aftermsSinceUserIntervention()is null (before: 1)apps/desktop: tsc, biome, vitest (1052) green.desktop-bridge: type-check, tests, biome green. Root:check:comment-hygiene,check:desktop-bridge,check:desktop-ipcgreen.Checklist