Skip to content

fix(google-ads): align reporting with current API access - #8812

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/google-ads-cloud-access
Oct 8, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/google-ads-cloud-access

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the retired developer-token requirement and use the OAuth client's Google Cloud API access level, as documented in Google's migration guide.
  • Replace removed campaign date fields while preserving date-only outputs, expose continuation tokens for reports, and validate date bounds and limits without rejecting omitted nullable limits.
  • Drop retired credential fields from shared exports and sanitized version reads using the existing migration registry; stored snapshots and authorized original-version reads remain unchanged.
  • Update setup and query guidance for account discovery, pagination, daily aggregation and reporting. OAuth permissions and the supported v24 API version stay unchanged.

Testing

  • Root bun run test: 20 workspace tasks, including 36,750 app tests with 25 existing skips.
  • 44 loopback HTTP checks exercise real request preparation and parsers. Initial regressions and nine review cases failed before their fixes. The fixture now projects dates only when selected and rejects changed continuation queries; independent query mutations fail the corresponding checks. These are synthetic provider responses, not live Google Ads acceptance.
  • Real PostgreSQL/Redis version-read regression fails before the sanitizer fix and passes afterward. Independently removing the retired-field and parked-field guards makes it fail; stored snapshots, unredacted authorized reads, unrelated historical field IDs, and unauthorized denial are preserved.
  • 268 focused serialization, migration, credential, comparison and export regressions; 26 workspace type checks; 58 audits; lint; generators; block registry; docs manifest; actionlint.
  • Hosted Google Ads reporting acceptance follows deployment to staging.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 8, 2026 9:25pm UTC

Request Review

@waleedlatif1
waleedlatif1 marked this pull request as ready for review October 8, 2026 21:06

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 19 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/google_ads/list_campaigns.ts Outdated
Comment thread apps/sim/tools/google_ads/types.ts Outdated
Comment thread apps/sim/tools/google_ads/campaign_performance.ts Outdated
@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issue remains from this review.

Summary

This PR removes the retired Google Ads developer-token requirement, updates campaign date fields, and adds continuation tokens and stricter input checks.

  • The latest changes preserve omitted limits and make nullable output declarations match returned data.
  • Both earlier, unnumbered review findings are addressed: shared version reads drop retired tokens, and the HTTP fixture checks date selections and unchanged continuation queries.
  • No new actionable issues were found. Live Google Ads reporting acceptance remains pending, as stated in the PR description.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Stored workflow version] --> B{Include credential values?}
  B -->|Yes| C[Return original snapshot]
  B -->|No| D[Clone snapshot]
  D --> E[Remove retired fields and hide credentials]
  E --> F[Return shared version]
Loading

Reviews (2) · Last reviewed commit: "fix(google-ads): preserve nullable input..." · Reviewed by Greptile

Comment thread apps/sim/lib/workflows/migrations/subblock-migrations.ts
Comment thread apps/sim/scripts/test-google-ads-e2e.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 21 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 039ae7a into staging Oct 8, 2026
38 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/google-ads-cloud-access branch October 8, 2026 21:32

This branch was previously deployed

1 inactive deployment
Preview — 150ff9f8 Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant