Repository navigation
feat(sim-cli): publish which CLI commands Mothership is refused, from the route admission rule - #8838
Merged
Merged
Conversation
… the route admission rule
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mothershipUnavailable: true. The worker hides those commands instead of keeping its own hand-written list, which had already drifted:whoamiandmeta statuswere shown in chat and then refused on every call.copilotRouteAudienceis pulled out ofcopilotRequestPrincipal. The copilot route inventory test evaluates it for every v2 route and also invokes each raw route handler once (chat, workflow execute, resume) with admission recorded, and writes the refused routes tocopilot-refused-routes.jsonas a file snapshot, which replaces the inline snapshot.print-command-inventory.tsreads that file.callsOperations, so the inventory can judge them as well.whoamideclaresgetMetaandgetWorkspace,files versions downloaddeclaresdownloadFileVersion, andsim chatdeclareschat. Generated commands still map to their operation by path.vitest run -u lib/api/server/routes/copilot-route-inventory.test.ts. That is the same workflow the inline snapshot needed.Type of Change
Testing
packages/sim-cli/src/contract/reference.test.tsruns the real inventory producer:meta status,whoami,files versions downloadandchatare flagged;workspaces get,workspaces invitations create,files getandworkflows runare not;apps/sim/lib/api/server/routes/(12 files, 325 tests).packages/sim-cli(52 files, 475 tests).bun run lint,bun run check:audits(58 audits) andbun run type-check.bun run test: everything passed except 3@sim/apptests that hit the 10s timeout under a concurrent load. Each of the three passes when rerun on its own.Checklist
test-auditauthoring gate)