improvement(editor): refine previews and compact formatting controls by waleedlatif1 · Pull Request #8860 · simstudioai/sim

waleedlatif1 · 2026-10-09T19:14:11Z

Summary

Shorten the text selection toolbar with Style and More menus while preserving existing formatting commands and shortcuts. Add Text and Heading 3 to match the insert menu.
Align source previews, text and table toolbars, and editor link cards with shared EMCN menu surfaces and controls.
Centralize neutral chip keyboard-focus styling in EMCN for buttons, links, and picker triggers; preserve selected surfaces in both segmented controls.
Keep typing in the editor after choosing a format, preserve Escape focus restoration, and retain read-only and table formatting restrictions.

Type of Change

Improvement

Testing

Full root test suite, including script tests and all workspace suites (36,890 app tests passing); adjacent editor tests (8 passing) and the existing chip-select test. Existing timing-sensitive billing and CLI-router tests needed unchanged reruns.
Root lint, all 26 workspace type checks, 58 audits, block registry, docs manifest, and actionlint 1.7.12.
Regenerated agent stream docs, docs manifest, and skill links with no generated changes.
Browser checks using the real components and editor extensions: dark/light previews, narrow layout and touch targets, pointer and keyboard menu navigation, selection preservation, Markdown round trips, Text conversion preserving inline marks, table restrictions, and closing menus when editing becomes read-only. Saved local screenshots.
Checked shared Chip focus in both themes: neutral buttons, links, and filled triggers use the focus surface; selected, primary, and destructive variants retain their colors. Verified selected ChipSwitch and ChipButtonGroup surfaces before/after the fix, arrow navigation, disabled-option skipping, and default/compact geometry.
No tests added or modified; validation uses existing suites and browser interaction checks.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-10-09T19:14:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Oct 9, 2026 8:20pm UTC

waleedlatif1 · 2026-10-09T19:14:24Z

@greptile

waleedlatif1 · 2026-10-09T19:14:26Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T19:14:31Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 5 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-09T19:19:56Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; both previous findings are fixed and no new blocking issue remains.

Summary

The PR compacts editor formatting into Style and More menus, aligns previews with shared controls, and centralizes neutral chip focus colors.

The editor’s selection toolbar keeps formatting in two compact menus.
Source previews fit into a narrower, tidier card.
Floating editor menus use the shared EMCN surface.
Neutral chips show a surface when focused by keyboard.

_{Reviews (4) · Last reviewed commit: "fix(emcn): preserve selected segment foc..." · Reviewed by Greptile}

waleedlatif1 · 2026-10-09T19:35:42Z

@greptile

waleedlatif1 · 2026-10-09T19:35:43Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T19:35:49Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-09T19:58:33Z

@greptile

waleedlatif1 · 2026-10-09T19:58:34Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T19:58:41Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 6 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-09T20:15:32Z

@greptile

waleedlatif1 · 2026-10-09T20:15:34Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T20:15:40Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 7 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

improvement(editor): refine previews and compact formatting controls

542fb1b

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread ...space/[workspaceId]/files/components/file-viewer/rich-markdown-editor/menus/toolbar-menu.tsx

fix(editor): retain focus after choosing a format

516fb13

vercel Bot temporarily deployed to Preview October 9, 2026 19:35 Inactive

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread ...space/[workspaceId]/files/components/file-viewer/rich-markdown-editor/menus/toolbar-menu.tsx Outdated

fix(emcn): centralize neutral chip keyboard focus

a9cfa2f

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

vercel Bot deployed to Preview October 9, 2026 20:05 View deployment

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread packages/emcn/src/components/chip/chip.tsx

fix(emcn): preserve selected segment focus surfaces

f7adb15

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

vercel Bot deployed to Preview October 9, 2026 20:20 View deployment

waleedlatif1 merged commit 903c16d into staging Oct 9, 2026
50 of 51 checks passed

waleedlatif1 deleted the codex/refine-previews-and-formatting branch October 9, 2026 22:20

waleedlatif1 mentioned this pull request Oct 9, 2026

v0.9.17: tables ledger, oracle integrations, mship improvements #8853

Open

Conversation

waleedlatif1 commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Oct 9, 2026 •

edited

Loading

vercel Bot commented Oct 9, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 9, 2026 •

edited

Loading