Repository navigation
fix(mothership): show the copy control for API keys created in organization chat - #8861
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{value, type}) and the persisted redaction ({type}) each rebuilt thesim_keyrow from scratch and dropped itsworkspaceId. Organization chat requires that field on every workspace-targeted credential row. Workspace chat was unaffected, because its check allows a row without a target.generate_api_keyresult says it was created in, and the live fill writes that workspace onto the row. The creation result outranks the model's tag, so the chip mounts under the key's real workspace even when the tag omits or misnames it.workspaceIdonly when the renderer would accept it as a target (non-empty, trimmed, at most 256 characters). It still strips the value and any other field, for both the singleton and the array tag forms.CredentialDisplayapplies the one-workspace-target rule only to a revealedsim_key. A masked row has nothing to copy and mounts no host, so a saved key renders as the masked chip in any chat, as it did before. Revealed keys still need a valid target in organization chat.Type of Change
Testing
special-tags.test.tsx): a key captured from agenerate_api_keyresult, filled live and rendered on an organization route, now shows the key. The persisted form renders masked with no refusal. Against the old code it fails with the exact refusal text, and reverting either the fill or the redaction change on its own turns it red.special-tags.test.tsx: in a workspace chat, a saved key whose tag names a different workspace renders masked, with no refusal line and no copy button.sim-key-redaction.test.ts:bun run --cwd apps/sim teston lib/mothership/chat and home/: 1025 passed. Rootbun run test: everything passed except 2 unrelated load flakes (usage-log,chat-contentlinearity), which pass when run alone.bun run lint,bun run check:audits,bun run type-check: clean.Checklist
test-auditauthoring gate)