Skip to content

fix(tests): cross the large-array threshold with 64 wide rows instead of 120k #8939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Oct 12, 2026
Merged

fix(tests): cross the large-array threshold with 64 wide rows instead of 120k #8939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions apps/sim/lib/function-execution/execute-request.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,10 @@ vi.mock('@/lib/function-execution/sandbox-mounts', () => ({
import { validateExternalUrl } from '@/lib/core/security/input-validation'
import { clearLargeValueCacheForTests } from '@/lib/execution/payloads/cache'
import { isLargeArrayManifest } from '@/lib/execution/payloads/large-array-manifest-metadata'
import { isLargeValueRef } from '@/lib/execution/payloads/large-value-ref'
import {
isLargeValueRef,
LARGE_VALUE_THRESHOLD_BYTES,
} from '@/lib/execution/payloads/large-value-ref'
import * as fileMaterialization from '@/lib/execution/payloads/materialization.server'
import { executeFunctionRequest } from '@/lib/function-execution/execute-request'
import { ResolvedSecretTraceRegistry } from '@/executor/utils/resolved-secret-trace-registry'
Expand Down Expand Up @@ -820,11 +823,13 @@ describe('Function execution request', () => {

describe('Basic Function Execution', () => {
it('compacts large array result fields to manifests when execution context is durable', async () => {
// Compaction cost scales with element count, so a few wide rows cross the threshold cheaply.
const rowCount = 64
mockExecuteInIsolatedVM.mockResolvedValueOnce({
result: {
rows: Array.from({ length: 120_000 }, (_, index) => ({
rows: Array.from({ length: rowCount }, (_, index) => ({
key: `SIM-${index}`,
payload: 'x'.repeat(100),
payload: 'x'.repeat(LARGE_VALUE_THRESHOLD_BYTES / rowCount),
})),
},
stdout: '',
Expand All @@ -846,7 +851,7 @@ describe('Function execution request', () => {
expect(data.output.result.rows).toMatchObject({
__simLargeArrayManifest: true,
kind: 'array',
totalCount: 120_000,
totalCount: rowCount,
})
})

Expand Down
Loading