Skip to content

feat(apollo): add optional OAuth connections - #9922

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/apollo-oauth
Nov 12, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/apollo-oauth

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add Apollo OAuth connections alongside existing saved and inline API keys.
  • Support partner authorization, rotating refresh tokens, and self-hosted client setup; offer OAuth only when its client is configured and workspace policy permits it.
  • Validate mixed credential pickers while preserving the existing API-key request path.

Type of Change

  • New feature

Testing

  • Apollo OAuth protocol and profile validation tests, including negative controls for URL encoding, provider identity, and response byte limits
  • Saved-credential contract and sibling credential, block, and availability tests
  • Live OAuth code exchange, profile verification, bearer-token API request, rotating refresh, and refreshed-token read (5/5 checks)
  • Production app build and organization-search browser scenario (20 checks), plus redirect-classification negative controls
  • Full repository lint, type-check, audits, tests, and block-registry checks

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 12, 2026 5:31am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable new issues were found.

Summary

Adds optional Apollo OAuth connections alongside saved and inline API keys.

  • Apollo accounts can connect to workflows through OAuth.
  • Apollo tools use the selected credential’s matching authentication header.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Picker[Choose Apollo credential] --> OAuth[Saved OAuth account]
  Picker --> Key[Saved or inline API key]
  OAuth --> Refresh[Refresh token when needed]
  Refresh --> Bearer[Send Authorization header]
  Key --> ApiKey[Send X-Api-Key header]
  Bearer --> Apollo[Apollo API]
  ApiKey --> Apollo
Loading

Reviews (3) · Last reviewed commit: "fix(apollo): respect workspace policy fo..." · Reviewed by Greptile

Comment thread apps/sim/blocks/blocks/apollo.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 47 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 49 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 49 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — 7861e5a9 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant