Conversation
The v1 deprecation warnings fired on every WORKSPACE command and on every entry point that resolved to v1, telling owners of existing workspace groups to switch to clusters when nothing requires it. Keep warnings only where they steer a choice the caller is making now: manage_workspaces(), and the Fusion CREATE WORKSPACE GROUP and CREATE WORKSPACE commands, whose message now says new deployments should be clusters. Remove the rest: the other Fusion WORKSPACE commands and version-less SHOW REGIONS, the IN GROUP clause on Stage commands, and the version='v1' warning on manage_files, manage_regions, get_organization, get_secret and get_stage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kesmit13
requested review from
mgiannakopoulos,
pmishchenko-ua and
volodymyr-memsql
as code owners
October 1, 2026 19:09
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Checked-in generated documentation still publishes the previous warning policy.
Review effort: Balanced
Findings: 1
What changed in this PR
Narrows v1 deprecation warnings to workspace creation while keeping existing v1 resource operations silent.
Changes:
- Removes generic v1 management warnings.
- Warns only for workspace creation commands.
- Updates tests and source documentation.
| File | Description |
|---|---|
README.md |
Clarifies v1 warning scope. |
docs/src/api.rst |
Updates API deprecation guidance. |
singlestoredb/_management_version.py |
Removes deprecated-version constant. |
singlestoredb/management/_version_import.py |
Removes generic warning machinery. |
singlestoredb/management/files.py |
Makes v1 file management silent. |
singlestoredb/management/region.py |
Makes v1 region management silent. |
singlestoredb/fusion/handler.py |
Revises creation warning text. |
singlestoredb/fusion/handlers/workspace.py |
Limits warnings to creation commands. |
singlestoredb/fusion/handlers/utils.py |
Removes IN GROUP warnings. |
singlestoredb/fusion/handlers/stage.py |
Updates Stage help text. |
singlestoredb/fusion/README.md |
Softens v1 terminology. |
singlestoredb/tests/test_fusion.py |
Tests narrowed Fusion warnings. |
singlestoredb/tests/test_management_versioning.py |
Tests silent v1 routing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1 deprecation warnings added recently fired on nearly every v1 path, and read as if anyone still using workspace groups should switch to clusters. This narrows them to the places where the caller is making a choice that clusters should replace.
Still warns
manage_workspaces(): unchanged.CREATE WORKSPACE GROUP/CREATE WORKSPACE: the message is now "… is deprecated: new deployments should be clusters. Use CREATE CLUSTER instead."No longer warns
WORKSPACE/WORKSPACE GROUPcommands, and the version-lessSHOW REGIONSIN GROUPclause on Fusion Stage commandsversion='v1'(explicit, or inherited frommanagement.version) onmanage_files,manage_regions,get_organization,get_secretandget_stage._warn_if_deprecated_versionand theDEPRECATED_*constants are removed.The README,
docs/src/api.rst, the Fusion Stage help text and the Fusion README are updated to match.Not changed
.. deprecated::docstring notes onmanagement/v1/modules and classes (enforced byTestV1IsDocumentedAsDeprecated). They are documentation, not runtime warnings, so this PR leaves them alone. They could get the same softening in a follow-up.Test plan
pytest -n 0 -m 'not management' singlestoredb/tests/test_management_versioning.py singlestoredb/tests/test_fusion.py: 70 passedpre-commit run: cleandocs/src: no warnings fromapi.rstTestWorkspaceFusionliveIN GROUPtest now asserts no warning) run in CI / nightly🤖 Generated with Claude Code
Note
Low Risk
Behavior change is limited to fewer DeprecationWarnings and doc text; v1 APIs and Fusion commands still run, with tests updated for the new warning scope.
Overview
Narrows management API v1 deprecation warnings so they only fire when someone is choosing to create a new deployment, not when operating existing workspace groups.
Still warns:
manage_workspaces()(unchanged) and FusionCREATE WORKSPACE GROUP/CREATE WORKSPACE— message is now "… is deprecated: new deployments should be clusters. Use CREATE CLUSTER instead."No longer warns: other Fusion
WORKSPACE/WORKSPACE GROUPcommands (includingSHOW REGIONS), StageIN GROUP, andversion='v1'onmanage_files,manage_regions,get_organization,get_secret, andget_stage. The global_warn_if_deprecated_versionhook andDEPRECATED_MANAGEMENT_VERSIONconstants are removed.Docs (
README,api.rst, Fusion Stage help) and tests are updated to match the narrower policy.Reviewed by Cursor Bugbot for commit 2498f6b. Bugbot is set up for automated code reviews on this repo. Configure here.