Skip to content

feat(wallpapers-bing): restore preferred-region picker - #3

Open
perlowja wants to merge 1 commit into
singularityos-lab:mainfrom
perlowja:feat/bing-preferred-market-picker
Open

perlowja wants to merge 1 commit into
singularityos-lab:mainfrom
perlowja:feat/bing-preferred-market-picker

Conversation

@perlowja

@perlowja perlowja commented Sep 18, 2026 •

Copy link
Copy Markdown

Adds a Bing Preferred Region SelectionRow to the wallpapers-bing plugin settings.

The picker obtains available markets from the helper, reads the current preference through the helper, and delegates preference updates to the helper without accessing distro-specific configuration files.

Verified by building wallpapers-bing/libwallpapers-bing.so with Meson and Ninja in a Debian trixie container against the current libsingularity fallback.

AI assistance: disclosed

@perlowja
perlowja force-pushed the feat/bing-preferred-market-picker branch 2 times, most recently from 2dabaa1 to e395533 Compare September 18, 2026 20:15
@perlowja

Copy link
Copy Markdown
Author

@mirkobrombin bumping this one too - restores the preferred-region picker for the Bing wallpaper source.

@mirkobrombin

Copy link
Copy Markdown
Member

Singularity must stay distro-agnostic: the plugin shouldn't write another distro's config (~/.config/ncz-wallpaper/bing-markets) or hardcode the market list. Get markets from the helper's markets command and persist the choice through the helper. Also: bing_markets_updating is never set, use string.ascii_down() instead of ascii_lower, and drop the cix-installer/zoder references from comments.

@perlowja
perlowja force-pushed the feat/bing-preferred-market-picker branch from 0900713 to d1ef213 Compare September 30, 2026 00:22
Adds a Bing Preferred Region row to the plugin settings. Markets come from the helper's markets command and the choice is read and saved through its market command.

Assisted-by: Claude Code:claude-sonnet-5
Assisted-by: Codex:gpt-5.6-sol
AI-Scope: Wrote the picker row and the helper calls for listing, reading and saving the market.
@perlowja
perlowja force-pushed the feat/bing-preferred-market-picker branch from d1ef213 to c7c10c7 Compare October 7, 2026 18:43
@perlowja

perlowja commented Oct 7, 2026

Copy link
Copy Markdown
Author

@mirkobrombin fixed in c7c10c7 (squashed to one commit): markets come from the helper, bing_markets_updating is gone, ascii_down() is used, and the commit message no longer names any downstream project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants