wscons: Fix repeat key handling for multiple keys - #20
Open
uint23 wants to merge 1 commit into
Open
Conversation
Using a single old_value for repeat suppression fails if several keys are held; releasing one clears the repeat state for _all_ of the keys so the next repeat from another held key is reported as a new press. To fix, track key state for every key instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a single old_value for repeat suppression fails if several keys are held; releasing one clears the repeat state for all of the keys so the next repeat from another held key is reported as a new press.
To fix, track key state for every key instead
I encountered this issue when I was just using vim and pressed multiple keys at once.
A "diagram" to show you what I mean:
K1 and K2 are just 2 different keys.
The key_down array could also be compressed by using a bitmap instead of storing 700 or so bytes for KEY_CNT